Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Adding --v0-compatible flag #7065

Merged

Conversation

johanfylling
Copy link
Contributor

To make OPA behave as v0.x post v1.0 release.
If used simultaneously with --v1-compatible flag, the --v0-compatible flag takes precedence.

Also, future-proofing cmd package tests for 1.0.

To make OPA behave as v0.x post v1.0 release.
If used simultaneously with `--v1-compatible` flag, the `--v0-compatible` flag takes precedence.

Also, future-proofing `cmd` package tests for 1.0.

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Copy link
Member

@ashutosh-narkar ashutosh-narkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @johanfylling 👏

1 < 2
}`,
},
expectedErr: "rego_parse_error",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failed because v0 took precedence over v1, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct 👌

@johanfylling johanfylling merged commit 5521453 into open-policy-agent:main Sep 25, 2024
29 checks passed
@johanfylling johanfylling deleted the rego-v1/v0-compatible_flag branch September 25, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants