util+plugins: Fix potential memory leak with explicit timer cancellation. #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipaconrad
requested review from
anderseknert,
ashutosh-narkar and
johanfylling
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ashutosh-narkar
approved these changes
Oct 2, 2024
This commit adds a utility for explicitly creating cancelable timers, to avoid a possible memory leak caused by timer.After. This issue is fixed in Go 1.23, but since we're still on Go 1.21, this will resolve the possibility of leaks in the mean time. Signed-off-by: Philip Conrad <philip@chariot-chaser.net>
philipaconrad
force-pushed
the
philip/explicit-timer-cancel
branch
from
d6f9ada to
910f252
Compare
|
ℹ️ Rebasing the PR through the Github Web UI. Once it goes green, I'll squash and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This commit adds a utility for explicitly creating cancelable timers, to avoid possible memory leaks caused by some
time.Aftertimers inselectstatements never being GC'd properly. This issue is fixed in Go 1.23, but since we're still on Go 1.21, this will resolve the possibility of leaks in the mean time.The patch fixes every instance in OPA of
<-time.After(...)that we have, so this should fix the issue until OPA eventually upgrades to Go 1.23 (which changes the behavior oftime.After).Note: One of these instances occurs in
topdown/http.go, so after this fix is integrated into an OPA release, we may want to poke some OPA memory leak reporters again, especially if they were usinghttp.sendextensively in their policies.Additional Resources
time.Afterissue