Optimize biunify for term slices #7168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
eval-less-allocs
branch
from
b806265 to
a69ce05
Compare
srenatus
reviewed
Nov 11, 2024
anderseknert
force-pushed
the
eval-less-allocs
branch
from
a69ce05 to
e727ec8
Compare
srenatus
previously approved these changes
Nov 11, 2024
The construction of intermediate throwaway `ast.Array`s caused almost 5 million allocations when running `regal lint` against its own bundle. While the results are likely more impressive for Regal policies than the average one, this is still a substantial improvement across a large group of policies. **regal lint OPA main** ``` BenchmarkRegalLintingItself-10 1 3317838417 ns/op 6611412800 B/op 124873123 allocs/op ``` **regal lint this branch** ``` BenchmarkRegalLintingItself-10 1 3140384416 ns/op 6590159176 B/op 120098613 allocs/op ``` Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
eval-less-allocs
branch
from
e727ec8 to
0742a39
Compare
srenatus
changed the title
srenatus
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The construction of intermediate throwaway
ast.Arrays caused almost 5 million allocations when runningregal lintagainst its own bundle.While the results are likely more impressive for Regal policies than the average one, this is still a substantial improvement across a large group of policies.
regal lint OPA main
regal lint this branch