Apply copy propagation to support rules #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously copy propagation was only being applied to queries returned by partial eval. The assumption was that clients would typically be implemented to deal with queries and that support rules would be unhandled. In some cases though, clients may be capable of handling support rules. For them, it's better if we apply copy propagation to both queries and rule bodies. Note, we ensure that rule bodies are non-empty so that comparisons to parsed rules that are equivalent (but lacking a body) succeed. Fixes open-policy-agent#911 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously copy propagation was only being applied to queries returned
by partial eval. The assumption was that clients would typically be
implemented to deal with queries and that support rules would be
unhandled. In some cases though, clients may be capable of handling
support rules. For them, it's better if we apply copy propagation to
both queries and rule bodies.
Note, we ensure that rule bodies are non-empty so that comparisons to
parsed rules that are equivalent (but lacking a body) succeed.
Fixes #911