Skip to content

Commit

Permalink
Add fwts annotation for duplicate DT node entries.
Browse files Browse the repository at this point in the history
Reference bug: open-power/op-build#751

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
[stewart@linux.vnet.ibm.com: tweak message slightly]
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
  • Loading branch information
pridhiviraj authored and stewartsmith committed Dec 21, 2016
1 parent 7d6e738 commit 77be333
Showing 1 changed file with 19 additions and 1 deletion.
20 changes: 19 additions & 1 deletion core/device.c
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,25 @@ int dt_expand_node(struct dt_node *node, const void *fdt, int fdt_node)
* going for now, we may ultimately want to
* assert
*/
(void)dt_attach_root(node, child);
if (!dt_attach_root(node, child))
/**
* @fwts-label DTHasDuplicateNodeID
* @fwts-advice OPAL will parse the Flattened
* Device Tree(FDT), which can be generated
* from different firmware sources. During
* expansion of FDT, OPAL observed a node
* assigned multiple times (a duplicate). This
* indicates either a Hostboot bug *OR*, more
* likely, a bug in the platform XML. Check
* the platform XML for duplicate IDs for
* this type of device. Because of this
* duplicate node, OPAL won't add the hardware
* device found with a duplicate node ID into
* DT, rendering the corresponding device not
* functional.
*/
prlog(PR_ERR, "DT: Found duplicate node: %s\n",
child->name);
break;
case FDT_END:
return -1;
Expand Down

0 comments on commit 77be333

Please sign in to comment.