Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading Bar component does not work #289

Closed
2 tasks done
FlorianK13 opened this issue Sep 12, 2024 · 0 comments · Fixed by #297
Closed
2 tasks done

Loading Bar component does not work #289

FlorianK13 opened this issue Sep 12, 2024 · 0 comments · Fixed by #297
Labels
bug Something isn't working

Comments

@FlorianK13
Copy link
Member

FlorianK13 commented Sep 12, 2024 •
edited
Loading

The loading bar component does not really work. It does not get the progress from the simulation and it jumps back when the diffuse radiation is simulated. Should we replace it with this spinner component from chakra @khdlr @MartGro ?

  • Replace or repair loading bar
  • Place loading bar messages in chakra card component (for better margin / padding)
@FlorianK13 FlorianK13 added the bug Something isn't working label Sep 12, 2024
FlorianK13 added a commit that referenced this issue Sep 15, 2024
@FlorianK13
Add margin to message text #289
c4eece5
@FlorianK13 FlorianK13 linked a pull request Sep 15, 2024 that will close this issue
Add margin to message text #289 #297
Merged
FlorianK13 added a commit that referenced this issue Sep 15, 2024
@FlorianK13
Merge pull request #297 from open-pv/289-formatting-loading-bar-message
5bf0830 
Add margin to message text #289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add margin to message text #289 open-pv/website
1 participant
@FlorianK13