Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a calculation of savings #243

Merged
merged 10 commits into from
Aug 31, 2024
Merged

Add a calculation of savings #243

merged 10 commits into from
Aug 31, 2024

Conversation

FlorianK13
Copy link
Member

@FlorianK13 FlorianK13 commented Aug 31, 2024 •
edited
Loading

  • use existing react State pvSystems to contain relevant information
  • refactored creation of pv systems to an own function
  • take information from pvSystems to get annual yield for savings
  • create function to calculate savings based on consumption, production, storage

@FlorianK13 FlorianK13 linked an issue Aug 31, 2024 that may be closed by this pull request
Add a calculation of yearly savings #242
Closed
@FlorianK13
Copy link
Member Author

grafik

khdlr
khdlr approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@khdlr khdlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we add a disclaimer saying that these are just rough estimates? "Angaben ohne Gewähr" or something?

@FlorianK13
Copy link
Member Author

Yes, disclaimer and all translations are missing. I will add these now.

@FlorianK13 FlorianK13 merged commit 1405307 into main Aug 31, 2024
@FlorianK13 FlorianK13 deleted the 242-calculate-savings branch August 31, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khdlr khdlr khdlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a calculation of yearly savings
2 participants
@FlorianK13 @khdlr