Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly scale the progress bar #296

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Correctly scale the progress bar #296

merged 1 commit into from
Sep 14, 2024

Conversation

khdlr
Copy link
Member

@khdlr khdlr commented Sep 14, 2024

Minor fix (obscured by autoformatter stuff), really only changes:

    function loadingBarWrapperFunction(progress, total = 100) {
      return window.setSimulationProgress(progress)
    }

to

    function loadingBarWrapperFunction(progress, total) {
      return window.setSimulationProgress((progress * 100) / total)
    }

@khdlr
Copy link
Member Author

khdlr commented Sep 14, 2024

This will work its full magic only together with open-pv/simshady#32 🪄 🔮

@khdlr khdlr requested a review from FlorianK13 September 14, 2024 11:39
@khdlr khdlr merged commit eb02ef9 into main Sep 14, 2024
@khdlr khdlr deleted the fix/progress-bar branch September 14, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants