Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take stock of common code #849

Closed
baentsch opened this issue Nov 5, 2020 · 3 comments
Closed

Take stock of common code #849

baentsch opened this issue Nov 5, 2020 · 3 comments
Milestone

Comments

@baentsch
Copy link
Member

baentsch commented Nov 5, 2020

Determine which common code is actually being used by (which) QSC algorithms and which common code may be missing (incremental SHA? Additional OpenSSL wrappers to be added?)

Goal: Have a "fall-back" code base for environments where OpenSSL is not available. In general, though, rely on OpenSSL for performance and reliability of implementation as default "common crypto" provider (possibly make such statement in README somewhere?)

@dstebila dstebila added this to the 0.5.0 RC1 milestone Dec 10, 2020
baentsch added a commit that referenced this issue Dec 16, 2020
@baentsch baentsch mentioned this issue Dec 16, 2020
2 tasks
@baentsch
Copy link
Member Author

baentsch commented Feb 3, 2021

Looks like this issue is the last hold-up for releasing 0.5.0. Merging #873 will not close this as that PR's script is only giving an indication as to which algorithms use which common code. If I recollect our conversations right we discussed also the "inverse" (to also check which additional common code would be good to add to liboqs). For that we'd need to review each algorithm implementation for "common code additions" -- or alternatively ask algorithm providers what they're missing in terms of common code (analogous to this discussion): Is my recollection and options to close correct? Additional thoughts?

@christianpaquin
Copy link
Contributor

Do we want to wait for this for 0.5? I'm fine to deal with this in the next release?

@dstebila dstebila removed this from the 0.5.0 RC1 milestone Feb 17, 2021
@dstebila dstebila added this to the 0.5.1 RC1 milestone Feb 24, 2021
dstebila pushed a commit that referenced this issue Apr 16, 2021
@baentsch
Copy link
Member Author

Considering resolved as per discussion in #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants