Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the Zephyr CI tests #1714

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix for the Zephyr CI tests #1714

merged 1 commit into from
Mar 1, 2024

Conversation

Frauschi
Copy link
Contributor

@Frauschi Frauschi commented Mar 1, 2024

The Zephyr Github CI Actions used a complete Zephyr installation to build and run the test code. The resulting size of the data has been up to several GBs, overfilling the Github runner storage space.

With this patch of the Zephyr workflow, only a minimal Zephyr installation is created to run the tests, resulting in a much smaller space footprint.

Furthermore, the timeout of the Signature test has been increased, as sometimes the tests take longer than the prior 10 minutes.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

The Zephyr Github CI Actions used a complete Zephyr installation to
build and run the test code. The resulting size of the data has been up
to several GBs, overfilling the Github runner storage space.

With this patch of the Zephyr workflow, only a minimal Zephyr
installation is created to run the tests, resulting in a much smaller
space footprint.

Furthermore, the timeout of the Signature test has been increased, as
sometimes the tests take longer than the prior 10 minutes.

Signed-off-by: Tobias Frauenschläger <t.frauenschlaeger@me.com>
@Frauschi Frauschi requested a review from dstebila as a code owner March 1, 2024 12:10
@Frauschi Frauschi mentioned this pull request Mar 1, 2024
2 tasks
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix, @Frauschi ! @SWilson4 please take a look, approve & re-base #1710.

@baentsch baentsch requested a review from SWilson4 March 1, 2024 13:31
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for sorting this out @Frauschi!

@SWilson4 SWilson4 merged commit 5690bae into open-quantum-safe:main Mar 1, 2024
42 checks passed
Eddy-M-K pushed a commit to Eddy-M-K/liboqs that referenced this pull request Apr 5, 2024
Create only a minimal Zephyr installation to run CI tests and increase timeout of the Signature test.

Signed-off-by: Tobias Frauenschläger <t.frauenschlaeger@me.com>
Signed-off-by: Eddy Kim <Eddy.M.Kim@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants