Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching to dev mode again #1743

Merged
merged 5 commits into from
Apr 3, 2024
Merged

switching to dev mode again #1743

merged 5 commits into from
Apr 3, 2024

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Apr 2, 2024

Moving version number forward. Also tests MacOS CI dependencies.

@baentsch baentsch marked this pull request as ready for review April 2, 2024 08:59
@baentsch baentsch requested a review from dstebila as a code owner April 2, 2024 08:59
@dstebila
Copy link
Member

dstebila commented Apr 2, 2024

In my own dev environment I've been getting annoying python3 failure messages from brew that mention pipx, but I haven't figured out what I'm actually supposed to do. Is it as simple as using pipx instead of pip3 everywhere?

@baentsch
Copy link
Member Author

baentsch commented Apr 2, 2024

In my own dev environment I've been getting annoying python3 failure messages from brew that mention pipx, but I haven't figured out what I'm actually supposed to do. Is it as simple as using pipx instead of pip3 everywhere?

No clue yet. Without local MacOS environment, I'm trying remote CI debugging right now. Turnaround sucks. If you'd have time and a local environment with the same problem, please give it a go.

@dstebila
Copy link
Member

dstebila commented Apr 2, 2024

In my own dev environment I've been getting annoying python3 failure messages from brew that mention pipx, but I haven't figured out what I'm actually supposed to do. Is it as simple as using pipx instead of pip3 everywhere?

No clue yet. Without local MacOS environment, I'm trying remote CI debugging right now. Turnaround sucks. If you'd have time and a local environment with the same problem, please give it a go.

It seems like this is a general Python ecosystem change, not just macOS, so eventually you may have this problem to look forward to on Linux. Apparently the idea is to force people to do package management properly. At least that's what I learned from this discussion thread

pipx is apparently not a drop-in replacement for pip3; in particular pipx won't work with libraries, only applications, and the case in which I encountered this was about a library. For libraries apparently the preferred approach is to create a virtual environment (yuck) that installs the desired library locally for the place you're using it, rather than system-wide. It is apparently possibly to bypass the restrictions on pip3 and get the behaviour we're used to by passing the flag --break-system-packages, but this is not preferred since it doesn't do proper package management.

@baentsch
Copy link
Member Author

baentsch commented Apr 2, 2024

since it doesn't do proper package management.

Do we need to care about this in a temporary CI environment? Just giving the option a go....

@dstebila
Copy link
Member

dstebila commented Apr 2, 2024

since it doesn't do proper package management.

Do we need to care about this in a temporary CI environment? Just giving the option a go....

Probably it's fine, give it a try.

@baentsch
Copy link
Member Author

baentsch commented Apr 2, 2024

Probably it's fine, give it a try.

Just done -- without DCO/-s option, though :-( That anyway makes me wonder: Why did we activate that? Wouldn't it be more reasonable that maintainers add this to commits while reviewing and not contributors? Any documentation how LF wants us to use this feature?

@baentsch
Copy link
Member Author

baentsch commented Apr 2, 2024

Probably it's fine, give it a try.

Just done -- without DCO/-s option, though :-( That anyway makes me wonder: Why did we activate that? Wouldn't it be more reasonable that maintainers add this to commits while reviewing and not contributors? Any documentation how LF wants us to use this feature?

Tagging @ryjones also here: Any documentation that'd help us understand what you want us to do wrt DCO?

baentsch added 5 commits April 2, 2024 22:35
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
@baentsch
Copy link
Member Author

baentsch commented Apr 2, 2024

For now, I try to remember adding "-s" to commit messages. Not exactly rocket science, but I'm not sure what this buys us (or any other committer). But again, suggest to add this new LF formalism "HowTo" also to https://openquantumsafe.org/about/#getting-started.

@baentsch
Copy link
Member Author

baentsch commented Apr 3, 2024

@SWilson4 please provide second review and approval to this "quick fix". I think this is acceptable at this time as OQS did not agree to provide "production grade" software, so an addition like --break-system-packages seems "OK" for now.

@baentsch baentsch mentioned this pull request Apr 3, 2024
2 tasks
@baentsch baentsch merged commit 5ac9bcf into main Apr 3, 2024
77 checks passed
@baentsch baentsch deleted the mb-0101 branch April 3, 2024 13:19
Eddy-M-K pushed a commit to Eddy-M-K/liboqs that referenced this pull request Apr 5, 2024
* switching to dev mode again

* activating backwards compatible pip3 mode

Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Eddy Kim <Eddy.M.Kim@outlook.com>
SWilson4 pushed a commit that referenced this pull request Jun 5, 2024
* switching to dev mode again

* activating backwards compatible pip3 mode

Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants