-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow windows linking of test programs #1751
Allow windows linking of test programs #1751
Conversation
Signed-off-by: Mattias Lindblad <matlin@gmail.com>
9a017a0
to
6182fdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks very much for this contribution @matlimatli !
Note to self and @smcmahonibm: Let's consider adding a CI test for this config if this is more widely used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
@baentsch @SWilson4 @matlimatli I saw this a bit late.. the easiest (imo) fix is to use the CMake flag |
Thanks for the suggestion, @vsoftco . I do like the fix in this PR, though, as it doesn't depend on the setting of a |
I don't think there's anything that |
@vsoftco I didn't know about that option. Thanks for pointing it out, it might come in handy in some situations! |
Worthwhile a documentation PR, e.g., here? |
The kat_kem and kat_sig programs could not be linked when building natively on windows. This was caused by multiple definitions of symbols. By using the
/FORCE:MULTIPLE
compiler option, this is allowed, similar in spirit to what was already used for cross-compiling to Windows.Fixes #1749