Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues with the push manifest CI workflow #333

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ajbozarth
Copy link
Member

Contrary to my prior understanding, local workflows can not be called in the uses of a step, only in the uses of a job.

I have update all the workflows to use the push-manifest.yml workflow at the job level instead of step.

Contrary to my prior understanding, local workflows can not be
called in the uses of a step, only in the uses of a job.

I have update all the workflows to use the push-manifest.yml
workflow at the job level instead of step.

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth ajbozarth requested a review from baentsch December 17, 2024 18:50
@ajbozarth
Copy link
Member Author

As a bit of extra explanation following my comments in todays call: The uses of a job can be a workflow as I had already done in build.yml but the uses of a step must be an "action" not a workflow. Actions work the same way, but are referenced differently. Actions must be located in the action.yml and are referenced by their directory, so one action per directory. I could have written the solution by moving push-manifest.yml to an action, but I felt this solution was cleaner and more in line with my other work.

@ajbozarth
Copy link
Member Author

Also unlike my previous attempt this was (brute-force) tested on my fork. I deleted/commented out all the code referencing the oqs-arm64 runner and dockerhub so it would successfully run, but the core solution did work.

@ajbozarth ajbozarth self-assigned this Dec 17, 2024
@baentsch baentsch merged commit dfb9248 into open-quantum-safe:main Dec 18, 2024
40 of 41 checks passed
@ajbozarth ajbozarth deleted the realfix branch December 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants