Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to inherit secrets between workflows #335

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ajbozarth
Copy link
Member

By default called workflows don't have access to secrets, this causes issues when needing access to our dockerhib secrets for push.

This adds secrets: inherit to all local workflow calls.

Fixes #334

By default called workflows don't have access to secrets, this
causes issues when needing access to our dockerhib secrets for push.

This adds `secrets: inherit` to all local workflow calls

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth ajbozarth self-assigned this Dec 18, 2024
@ajbozarth ajbozarth requested a review from baentsch December 18, 2024 17:02
@ajbozarth
Copy link
Member Author

Sorry for the continued CI thrash, this was another case of being unable to test prior to merge since it's an issue with secrets. Note that is still the case with this fix, I have no way to test it prior to merge, but based on the following excepts from this docs section I believe this should be the fix.

Workflows that call reusable workflows in the same organization or enterprise can use the inherit keyword to implicitly pass the secrets.

If the secrets are inherited by using secrets: inherit in the calling workflow, you can reference them even if they are not explicitly defined in the on key.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's give it a try

@baentsch baentsch merged commit 9758c50 into open-quantum-safe:main Dec 18, 2024
28 of 29 checks passed
@ajbozarth ajbozarth deleted the secrets branch December 18, 2024 17:13
@ajbozarth
Copy link
Member Author

And finally success! All green on main (except the failing openvpn one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails on auth when trying to push
2 participants