Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full Windows support #192

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Add full Windows support #192

merged 4 commits into from
Jun 23, 2023

Conversation

baentsch
Copy link
Member

Fixes #47

@baentsch baentsch marked this pull request as ready for review June 21, 2023 06:24
@baentsch baentsch requested a review from dstebila June 21, 2023 06:24
@baentsch
Copy link
Member Author

@dstebila When this merges, please also feel free to turn off the Windows VM you kindly made available for helping me test this platform.

@christianpaquin This PR FYI ("you" being MSFT :) -- maybe this helps you wean off off OpenSSL111.

christianpaquin
christianpaquin reviewed Jun 22, 2023
View reviewed changes
Copy link

@christianpaquin christianpaquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did these tests run on this PR?

@baentsch
Copy link
Member Author

LGTM. Did these tests run on this PR?

Yes -- Click on the green checkmarks of commits not tagged "skip ci" above.

dstebila
dstebila approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@dstebila dstebila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed the PR but haven't the expertise to evaluate it properly, nor have I run it. Best if @christianpaquin gives a look as well before merging.

@dstebila
Copy link
Member

@dstebila When this merges, please also feel free to turn off the Windows VM you kindly made available for helping me test this platform.

I only read the last clause of that sentence, so I already turned it off. 😝 Let me know if you need it back on.

@baentsch baentsch merged commit 4ab1749 into main Jun 23, 2023
@baentsch baentsch deleted the mb-winci branch June 23, 2023 04:58
@baentsch baentsch mentioned this pull request Jun 26, 2023
Closed
@baentsch baentsch mentioned this pull request Sep 14, 2023
Open
4 tasks
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
@baentsch @feventura
Add full Windows support (open-quantum-safe#192)
56f38bf 
* adding full Windows build support

* add github badges

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianpaquin christianpaquin christianpaquin approved these changes

@dstebila dstebila dstebila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows support
3 participants
@baentsch @dstebila @christianpaquin