Fix a minor bug in the runtests.sh.
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
runtests
branch
2 times, most recently
from
f5ac246 to
21fcdf5
Compare
This commit fixes a minor bug in `scripts/runtests.sh`: this script is run with POSIX sh on linux machines, meaning that `[[` are not recognized. However, `[[ … ]]` was used (see for instance [this CI job]). Because `set -e` was not set, the minor bug described above did not lead to a CI failure. This commit fixes the `[[ … ]]` by using a simple `if grep`. It also sets `set -e` at the top of the file in order to catch any potential future mistakes. Finally, this commit also fixes minor warnings raised by [ShellCheck]. To display those warnings, one can simply run `shellcheck scripts/runtests.sh`. [this CI job]: https://github.com/open-quantum-safe/oqs-provider/actions/runs/5527705776/jobs/10083733262#step:6:14 [ShellCheck]: https://www.shellcheck.net/
baentsch
approved these changes
Jul 18, 2023
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 16, 2024
This commit fixes a minor bug in `scripts/runtests.sh`: this script is run with POSIX sh on linux machines, meaning that `[[` are not recognized. However, `[[ … ]]` was used. Because `set -e` was not set, the minor bug described above did not lead to a CI failure. This commit fixes the `[[ … ]]` by using a simple `if grep`. It also sets `set -e` at the top of the file in order to catch any potential future mistakes. Finally, this commit also fixes minor warnings raised by [ShellCheck]. To display those warnings, one can simply run `shellcheck scripts/runtests.sh`. [ShellCheck]: https://www.shellcheck.net/ Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a minor bug in
scripts/runtests.sh: this script is run with POSIX sh on linux machines, meaning that[[are not recognized. However,[[ … ]]was used (see for instance this CI job).Because
set -ewas not set, the minor bug described above did not lead to a CI failure.This commit fixes the
[[ … ]]by using a simpleif grep. It also setsset -eat the top of the file in order to catch any potential future mistakes.Finally, this commit also fixes minor warnings raised by ShellCheck. To display those warnings, one can simply run
shellcheck scripts/runtests.sh.