Fix DOQS_ALGS_ENABLED setting for cmake #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baentsch
approved these changes
Aug 31, 2023
|
I personally think this (very correct) bug fix is a good contribution but not yet so significant to justify an entry in the "Contributors" section of the README.md: Would you agree, @marcbrevoort-cyberhive ? If not, please amend this PR suitably before we merge. Otherwise, please remember considering to add yourself to that list as part of a future PR (e.g., improving the build environment for static builds). |
|
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 16, 2024
Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the cmake flag so it reads
-DOQS_ALGS_ENABLED=<value>on line 109.This is based on the notion that the script works based on an environment variable that only contains the word "All" or "STD" for the setting rather than the entire cmake flag, and is consistent with the way the cmake flag for openssl location is set on line 100.