Address some Static Analysis Issues #519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Norman Ashley <nashley@cisco.com>
Signed-off-by: Norman Ashley <nashley@cisco.com>
Signed-off-by: Norman Ashley <nashley@cisco.com>
* add support for the CMAKE_PARAMS environment variable Signed-off-by: Jan Schaumann <jschauma@netmeister.org> --------- Signed-off-by: Jan Schaumann <jschauma@netmeister.org> Signed-off-by: Norman Ashley <nashley@cisco.com>
* update X25519-MLKEM768 code point Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> * further MLKEM (O)ID updates Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> * set p256_mlkem768 code point as per standard Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> --------- Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> Signed-off-by: Norman Ashley <nashley@cisco.com>
* Actionlint workflow checking Integrate Actionlint to check GitHub workflows for errors as part of CI. It also fixes issues highlighted in other workflows, primarily the `checkout` version and missing property. Signed-off-by: JP Lomas <jp@theqrl.org> * Update CODEOWNERS Signed-off-by: JP Lomas <jp@theqrl.org> --------- Signed-off-by: JP Lomas <jp@theqrl.org> Signed-off-by: Norman Ashley <nashley@cisco.com>
* add explicit usage warning [skip ci] Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> * copying the liboqs core warning over to avoid any misunderstanding [skip ci] Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> * Update README.md Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> * disable CF hybrid interop testing Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> --------- Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com> Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Norman Ashley <nashley@cisco.com>
Signed-off-by: Norman Ashley <nashley@cisco.com>
ashman-p
force-pushed
the
na_81_rsc_leak
branch
from
f55aa6a to
53a073e
Compare
|
Thanks very much for these better guards that I saw at first glance @ashman-p . To review more effectively could you please rebase to main, though to get rid of those changes also shown in this PR? |
My rebase did not seem to clear this up. Will cherry pick changes to a new branch and resubmit. |
ashman-p
added a commit
that referenced
this pull request
Sep 18, 2024
Address some Static Analysis Issues #519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some static analysis errors reported by Coverity tool.