Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed when building with a static libcrypto on Linux #584

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ashman-p
Copy link
Contributor

@ashman-p ashman-p commented Dec 8, 2024

Static OQSProvider builds fail when libcrypto is built 'no-shared'.

sample....

cmake -DOPENSSL_ROOT_DIR=/home/ubuntu/openssl3.3/ossl-install/  -DOQS_PROVIDER_BUILD_STATIC=ON -DCMAKE_PREFIX_PATH=/home/ubuntu/openssl3.3/ossl-install/ -DCMAKE_INSTALL_PREFIX=/home/ubuntu/openssl3.3/ossl-install/   -DCMAKE_BUILD_TYPE=Debug  -GNinja -S .. 
5. See error
FAILED: test/oqs_test_groups  : && /usr/bin/cc -g   test/CMakeFiles/oqs_test_groups.dir/oqs_test_groups.c.o test/CMakeFiles/oqs_test_groups.dir/test_common.c.o test/CMakeFiles/oqs_test_groups.dir/tlstest_helpers.c.o  -o test/oqs_test_groups  /home/ubuntu/openssl3.3/ossl-install/lib64/libssl.a  /home/ubuntu/openssl3.3/ossl-install/lib64/libcrypto.a  lib/liboqsprovider.a  /home/ubuntu/openssl3.3/ossl-install/lib/liboqs.a  /home/ubuntu/openssl3.3/ossl-install/lib64/libcrypto.a && : /usr/bin/ld: /home/ubuntu/openssl3.3/ossl-install/lib64/libcrypto.a(libcrypto-lib-threads_pthread.o): in function CRYPTO_THREAD_lock_new':

Fixes #575

Signed-off-by: Norman Ashley <nashley@cisco.com>
@ashman-p ashman-p requested a review from baentsch as a code owner December 8, 2024 19:50
@ashman-p ashman-p self-assigned this Dec 8, 2024
@ashman-p ashman-p requested review from dstebila and SWilson4 December 8, 2024 19:51
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Thanks for the improvement! Worthwhile adding a CI test case for such builds as part of this PR?

@baentsch
Copy link
Member

LGTM: Thanks for the improvement! Worthwhile adding a CI test case for such builds as part of this PR?

Merging without that then. Created #590 to track this possible improvement.

@baentsch baentsch merged commit 8cf2217 into open-quantum-safe:main Dec 12, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OQS Provider Static Build Fails
2 participants