Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanomole flow resubmission #70

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Nanomole flow resubmission #70

merged 2 commits into from
Mar 3, 2021

Conversation

mwleklin
Copy link
Contributor

@mwleklin mwleklin commented Mar 1, 2021

This dataset was prepared using the interactive editor and enumerated using command line. The set was validated using the validation script.

Resubmission.zip

image

@skearnes
Copy link
Contributor

skearnes commented Mar 1, 2021

Thanks Mike! Could you please revert your deletion of the data/ directory? Your fork is likely out of date since we've added a lot of datasets recently.

@skearnes skearnes requested a review from michaelmaser March 1, 2021 19:55
@mwleklin
Copy link
Contributor Author

mwleklin commented Mar 1, 2021

Thanks Mike! Could you please revert your deletion of the data/ directory? Your fork is likely out of date since we've added a lot of datasets recently.

Yes, not realizing how the clone works, I deleted that file in order to clone to my desktop. I get the following error when trying to download that data, any suggestions?

image

@skearnes
Copy link
Contributor

skearnes commented Mar 1, 2021 via email

@skearnes
Copy link
Contributor

skearnes commented Mar 1, 2021

I've never seen an error like that before; could be a firewall issue. You might try removing Git LFS and re-cloning (you shouldn't need it to submit). Then you won't be accessing files hosted off github...

@skearnes
Copy link
Contributor

skearnes commented Mar 1, 2021

Maybe try this: https://stackoverflow.com/a/42021818

@mwleklin
Copy link
Contributor Author

mwleklin commented Mar 2, 2021

Thanks, that made the clone work. I think I have the resubmission correctly now?

@skearnes
Copy link
Contributor

skearnes commented Mar 3, 2021

Thanks Mike! Validations look good, and I'll let @michaelmaser confirm the edits.

@skearnes skearnes changed the base branch from main to #70 March 3, 2021 19:32
@skearnes skearnes closed this Mar 3, 2021
@skearnes skearnes reopened this Mar 3, 2021
Copy link
Contributor

@michaelmaser michaelmaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Parsing and validations all working well. Reaction setup and components all looking good. Thanks Mike!

@skearnes skearnes merged commit 8f55354 into open-reaction-database:#70 Mar 3, 2021
skearnes added a commit that referenced this pull request Mar 3, 2021
* Add Data back in (#70)

Co-authored-by: mwleklin <michae.s.wleklinski@gmail.com>
Co-authored-by: Steven Kearnes <kearnes@google.com>

* Delete data/7d directory

* Delete data/33 directory

* Revert 7d deletion

* Update submission

Co-authored-by: mwleklin <44303709+mwleklin@users.noreply.github.com>
Co-authored-by: mwleklin <michae.s.wleklinski@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants