Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proto (textures, well plate locations) #595

Merged
merged 5 commits into from
May 26, 2021
Merged

Update proto (textures, well plate locations) #595

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8394bc
Solid/liquid textures; resolves #593
connorcoley Apr 28, 2021
d8ad0ea
Add wellplate identifiers; resolves #589
connorcoley Apr 28, 2021
a3c2d8b
New pylint
connorcoley Apr 28, 2021
f3df1b9
Merge branch 'main' into cwc-1
connorcoley May 26, 2021
6ee9989
Remove sketchy pylint fix in favor of context managers
connorcoley May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ord_schema/proto/reaction.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,11 @@ message Vessel {
repeated VesselAttachment attachments = 5;
// Size (volume) of the vessel.
Volume volume = 6;
// Identifier number for a microtiter plate or parallel reactor run.
string plate_id = 7;
// If a well-plate was used, the position of the well for this experiment,
// e.g., "A4".
string plate_position = 8;
}

message VesselMaterial {
Expand Down Expand Up @@ -847,6 +852,8 @@ message ProductCompound {
FOAM = 6;
WAX = 7;
SEMI_SOLID = 8;
SOLID = 9;
LIQUID = 10;
}
TextureType type = 1;
// Specify texture forms such as "fine needles" for CRYSTAL,
Expand Down
2 changes: 2 additions & 0 deletions ord_schema/resolvers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
_USERNAME = 'github-actions'
_EMAIL = 'github-actions@github.com'

# pylint: disable=consider-using-with


def canonicalize_smiles(smiles: str) -> str:
"""Canonicalizes a SMILES string.
Expand Down