Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.12 #105

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Support python 3.12 #105

merged 7 commits into from
Jun 24, 2024

Conversation

Bluesy1
Copy link
Collaborator

@Bluesy1 Bluesy1 commented Jun 21, 2024

Preparation for if/when conda-forge/miniforge#598 goes through, as PrairieLearn uses miniforge to install python to its environments, and they don't pin the python version.

See also: open-resources/problem_bank_helpers#37

@Bluesy1 Bluesy1 self-assigned this Jun 21, 2024
@Bluesy1 Bluesy1 changed the title Bump minimum version to python 3.12 Support python 3.12 Jun 24, 2024
@Bluesy1 Bluesy1 marked this pull request as ready for review June 24, 2024 20:08
@Bluesy1
Copy link
Collaborator Author

Bluesy1 commented Jun 24, 2024

For the record:

These failures are expected, unless/until the failing problem banks are fixed downstream (i.e. open-resources/instructor_stats_bank#955). But, the problem banks themselves cannot confirm everything is fixed upstream due to httpimport not working on python3.12, and before this PR, httpimport was used for vendoring a file from PraireLearn used for symbolic input question parts for question transpiling.

@Bluesy1 Bluesy1 merged commit a31dac7 into main Jun 24, 2024
13 of 15 checks passed
@Bluesy1 Bluesy1 deleted the python-312 branch June 24, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant