-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codeblock answer substitution #69
Conversation
These three can be handled in the same PR:
We should have a meeting about this to hammer out some things as it'll require some back and forth. |
The alternative I had thought of was to just move the body of the convert function into the injected code, and inject an If you want to have a meeting to discuss the different options, I can be available on Thursday for that. I'll go ahead and split the changes that aren't for the codeblocks into a different PR so those can be merged in separately since this may take some time to figure out the optimal solution for Edit: #70 has the split off changes |
d086e03
to
8e7c36a
Compare
I've rebased this off of #70 now, such that we can keep the changes in test running for anything made here, to be sure it works properly, but such that clean merging separately should hopefully be possible, though I suppose another rebase may be necessary down the line (should be relatively simple I think though) |
pl-matching
, tests, unicode changeNow, code is injected into `generate` to do the substitution at runtime
8e7c36a
to
864a247
Compare
Change implemented as discussed earlier, this should not be merged (or at least merged and released) until a new release of PBH with open-resources/problem_bank_helpers#17 merged is cut (and ideally the dependency is bumped here, but that doesn't matter as much) |
The changes here happened via cascade, I can split this into 4 separate PRs if wanted.
I recommend viewing the changes commit by commit, to understand what each is for:
pl-matching
question, I found and fixed an error with distractor answers (cc @amurph24 for https://github.com/open-resources/instructor_datascience_bank/pull/171#discussion_r1259040759)question.html
was being generated correctly, so I fixed thatResolves #68