Add support for workspaces and serverFilesQuestion #76
+1,254
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit: Jonatan Schroeder for the original question that was converted to markdown here
Bluesy1
commented
Jul 19, 2023
Comment on lines
+1103
to
+1106
|
|
||
| if os_errors: | ||
| error_msg = "\n ".join(os_errors) | ||
| raise FileNotFoundError(f"Error(s) copying specified files:\n {error_msg}") |
There was a problem hiding this comment.
The idea behind the try-except system here is to show all file copy errors to the best of our ability at once, instead of having it show up one file at a time.
The output of this should look something as follows, as an example:
FileNotFoundError: Error(s) copying specified files:
[Errno 2] No such file or directory: 'test0'
[Errno 2] No such file or directory: 'test1'
[Errno 2] No such file or directory: 'test2'
[Errno 2] No such file or directory: 'test3'
[Errno 2] No such file or directory: 'test4'
[Errno 2] No such file or directory: 'test5'
[Errno 2] No such file or directory: 'test6'
[Errno 2] No such file or directory: 'test7'
[Errno 2] No such file or directory: 'test8'
[Errno 2] No such file or directory: 'test9'
tests/test_question_templates/question_inputs/q16_workspaces/q16_workspaces.md
Show resolved
Hide resolved
tests/test_question_templates/question_inputs/q16_workspaces/q16_workspaces.md
Show resolved
Hide resolved
tests/test_question_templates/question_inputs/q16_workspaces/q16_workspaces.md
Show resolved
Hide resolved
amurph24
reviewed
Jul 20, 2023
It would be more ideal for the test to be in its own question, but at the moment I discern a simple test case that would test this elegantly
|
I think I looked at this a while ago, but forgot to merge it in... hopefully nothing has changed since then. |
firasm
approved these changes
May 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding the copy files code for workspaces/serverFiles, I updated the code such that it should now catch a wider set of missing files at once to help fix questions faster, instead of one file at a time.
It would be more ideal for the test for
serverFilesQuestionto be in its own case I admit, but at the moment I cannot discern a simple test case that would test this elegantlyResolves #75