Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker images #480

Open
1 task done
Yadunund opened this issue Jun 17, 2024 · 0 comments
Open
1 task done

Fix docker images #480

Yadunund opened this issue Jun 17, 2024 · 0 comments

Comments

@Yadunund
Copy link
Member

Yadunund commented Jun 17, 2024

Before proceeding, is there an existing issue or discussion for this?

Description

The DOCKERFILE on main uses humble as the underlay

FROM ros:humble AS builder

Following recent updates across the codebase to support Gazebo Harmonic and drop support for Gazebo Classic, the scheduled docker job fails since the required gz debs are not available on 22.04.

This leads to #477.

In #479 i've upgraded the underlay to rolling which is what it should be in main. Following that, we could update each distro branch to build with the corresponding underlay and create distro specific tags, ie, update

tags: latest
.

Personally I'm keen on dropping the docker images since this was something we needed before we overhauled our versioning and release process to release binaries more frequently. It seems like quite a hassle to maintain. But open to discussing this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant