Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address sanitizer fails on rolling because of uncrustify #12

Open
1 task done
luca-della-vedova opened this issue May 29, 2024 · 1 comment
Open
1 task done

Comments

@luca-della-vedova
Copy link
Member

Before proceeding, is there an existing issue or discussion for this?

Description

As documented in #10 (comment), it seems that the asan action fails on rolling because of uncrustify, possibly due to the fact that we use a custom style file throughout Open-RMF, the fact that the uncrustify version changed in 24.04 or both.
What is even more puzzling though, is that the normal build and test on Rolling / 24.04 succeeds, so it is not purely an uncrustify issue but seems to be related at the asan action.

@mxgrey
Copy link

mxgrey commented May 29, 2024

This is a really bizarre problem. In all honesty there's no reason for us to be running uncrustify during the asan test anyway.

While it's frustrating to simply cover up a problem without understanding it, I don't see much value in spending time to figure out what inexplicable combination of environment settings is causing this illogical outcome. We're actively working to retire this codebase, and I'd rather we focus on that rather than getting bogged down in parts of its CI that shouldn't even matter.

I would suggest we try to suppress uncrustify tests during asan runs using cmake test labels. I think if we give the uncrustify tests a label and just exclude that label during asan runs, we can just sidestep all this weirdness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants