Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service interface for typescript #451

Closed
wants to merge 1 commit into from
Closed

add service interface for typescript #451

wants to merge 1 commit into from

Conversation

encendre
Copy link

Attempt to solve #450

I modified getMethodTypings in the typescript generator so that it returns the interface as well.
Another solution would be to export a separate function that generates the interface.

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #451 (76ca637) into master (e168e2b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          167       172    +5     
  Branches        23        25    +2     
=========================================
+ Hits           167       172    +5     
Impacted Files Coverage Δ
src/typescript.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e0e935...76ca637. Read the comment docs.

@BelfordZ
Copy link
Member

awesome work @encendre

Ill check this out asap!

@encendre encendre closed this by deleting the head repository Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants