Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Backwards compatible logger #33

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix: Backwards compatible logger #33

merged 3 commits into from
Sep 20, 2024

Conversation

Meldiron
Copy link
Contributor

Manual QA:

Old santax:
CleanShot 2024-09-20 at 14 54 38@2x

CleanShot 2024-09-20 at 14 54 33@2x

CleanShot 2024-09-20 at 14 55 08@2x

New syntax:

CleanShot 2024-09-20 at 15 06 48@2x

CleanShot 2024-09-20 at 15 06 31@2x

CleanShot 2024-09-20 at 15 06 54@2x

Meldiron
Meldiron commented Sep 20, 2024
View reviewed changes
app/http.php

$providerName = $loggingProvider->getScheme();
$providerConfig = match ($providerName) {
'sentry' => ['key' => $loggingProvider->getPassword(), 'projectId' => $loggingProvider->getUser() ?? '', 'host' => 'https://' . $loggingProvider->getHost()],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for self, Add https://' . to host in executor too

Meldiron
Meldiron commented Sep 20, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@Meldiron Meldiron mentioned this pull request Sep 20, 2024
Merged
@Meldiron Meldiron merged commit 4de447d into main Sep 20, 2024
3 checks passed
@Meldiron Meldiron deleted the fix-logger-backwards-compatibility branch September 20, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meldiron @christyjacob4