fix: catch logerrors #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
reviewed
Dec 13, 2024
| try { | ||
| logError($error, "healthCheckError", $logger, null); | ||
| } catch (Throwable) { | ||
| Console::warning('Unable to send log message'); |
There was a problem hiding this comment.
We'd still spam the errors to the provider with this.
Also, logging doesn't throw an exception on error, does it?
There was a problem hiding this comment.
NVM ..it does
Maybe catch and log the error to the console
There was a problem hiding this comment.
And maybe make the change in the logError function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap all calls to
logErrorinside a try catch, so we don't spam sentry.