Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: refactor constant naming #281

Closed
1 of 2 tasks
a0m0rajab opened this issue Nov 7, 2023 · 3 comments · Fixed by #286
Closed
1 of 2 tasks

Feature: refactor constant naming #281

a0m0rajab opened this issue Nov 7, 2023 · 3 comments · Fixed by #286

Comments

@a0m0rajab
Copy link
Contributor

Type of feature

🍕 Feature

Current behavior

The constants naming that we have right now is confusing since we are referring to classes as selectors.
Which i would suggest to fix that to have a better and less confusing developer experience while coding.

Example:

// Content-scripts selectors
export const GITHUB_REVIEW_SUGGESTION_SELECTOR = "js-suggestion-button-placeholder";

Suggested solution

Rename the shown class as :

export const GITHUB_REVIEW_SUGGESTION_CLASS= "js-suggestion-button-placeholder";

This could apply on other selectors as well.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@codewithjazzy
Copy link
Contributor

.take

Copy link

🎉 This issue has been resolved in version 1.14.3-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants