Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Design a Loading component to be used in components waiting for data #751

Closed
1 of 2 tasks
nightknighto opened this issue Dec 31, 2022 · 2 comments
Closed
1 of 2 tasks

Comments

@nightknighto
Copy link
Contributor

nightknighto commented Dec 31, 2022

Type of feature

🍕 Feature

Current behavior

Currently how the system is designed is that if a component is waiting for data, it will not show anything till it retrieves the data. It's better to have a Loading Component and use it when data is loading to give feedback to the user.

We have started implementing error / loading handling in #738 , which displays <div> Loading... </div> in case the data is still loading.

Idea credits to @0-vortex

Suggested solution

Make a component that indicates to the user that this thing is still loading and add it to Design system. (Storybook)

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@brandonroberts
Copy link
Contributor

@bdougie
Copy link
Member

bdougie commented Feb 28, 2023

The skeleton wrapper is all that is needed here.

@bdougie bdougie closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants