feat: add Edit Page button to insight pages #738

nightknighto · 2022-12-25T19:41:42Z

What type of PR is this? (check all applicable)

Description

Adds an Edit Button inside of existing Insight Pages to navigate easily to editing the page from inside.

Related Tickets & Documents

fixes #685

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2022-12-25T19:41:49Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`2174c92`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/63b08656d29aa3000968da6a
😎 Deploy Preview	https://deploy-preview-738--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-12-25T19:41:50Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`2174c92`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/63b08656d05d3b00088586fb
😎 Deploy Preview	https://deploy-preview-738--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bdougie

Edit button should only appear for the owner (public pages show edit button) and logged in users

bdougie

Looks good. Let's wait on a second review to confirm the path leveraging user ids from supabase is the ideal path.

components/molecules/InsightHeader/insight-header.tsx

NsdHSO

LGTM

layouts/hub-page.tsx

components/molecules/InsightHeader/insight-header.tsx

Co-authored-by: Brandon <robertsbt@gmail.com>

0-vortex

Couple of lines on line 32 IMHO, simple error and owner checking should ideally happen where the insight hook is first called; this can rotate the props sent to the header to provide errors (when any), and correctly differentiate between public, logged-in public, and logged-in owners.

Assume this is only adding the button, there should be some URL deduplication guards to check for the same things mentioned above and disable white/broken or public edit links. Is this accounted for in another issue?

layouts/hub-page.tsx

nightknighto · 2022-12-28T19:24:54Z

I tried a trick from google to fix the showing of commits from previous PRs and it worked, but it seems ot have deleted some of the conversations that were related to them. Sorry for that @0-vortex

0-vortex · 2022-12-28T19:40:22Z

I tried a trick from google to fix the showing of commits from previous PRs and it worked, but it seems ot have deleted some of the conversations that were related to them. Sorry for that @0-vortex

Np, it's still in the previous commit history conversation, didn't disappear fully just got hidden! 🍕

lib/hooks/useSupabaseAuth.ts

brandonroberts · 2022-12-29T14:30:38Z

@Deadreyo deploy preview failed due to type error during build. Everything else LGTM

## [1.23.0-beta.6](v1.23.0-beta.5...v1.23.0-beta.6) (2023-01-03) ### 🍕 Features * add Edit Page button to insight pages ([#738](#738)) ([bde1eb8](bde1eb8)), closes [#685](#685) * enable repository selection & add to new insights page ([#693](#693)) ([ba6405d](ba6405d)), closes [#593](#593) [#592](#592) ### 🐛 Bug Fixes * add missing title props ([cdcc28d](cdcc28d))

## [1.23.0](v1.22.2...v1.23.0) (2023-01-05) ### 🧑‍💻 Code Refactoring * update pr velocity indicator ([#707](#707)) ([7e96735](7e96735)), closes [#684](#684) ### 🐛 Bug Fixes * add missing title props ([cdcc28d](cdcc28d)) * correct some tooling and dependency issues ([#749](#749)) ([cb4ec9f](cb4ec9f)) * only pull insights for stacked avatar on insight pages ([#761](#761)) ([80ae119](80ae119)) * overflow x bug on dashboard ([#709](#709)) ([b022dbc](b022dbc)), closes [#677](#677) * user profile auth avatar processing errors ([#755](#755)) ([3ba87a6](3ba87a6)), closes [#733](#733) ### 🍕 Features * add Edit Page button to insight pages ([#738](#738)) ([bde1eb8](bde1eb8)), closes [#685](#685) * add favorite repos on the design system ([#744](#744)) ([c8660b5](c8660b5)), closes [#717](#717) * add hover card and expand on contributor stack ([#742](#742)) ([9f45b3d](9f45b3d)) * adjust search font-size ([c451450](c451450)) * change name to enhace from logarithmic ([#743](#743)) ([4384324](4384324)) * enable repository selection & add to new insights page ([#693](#693)) ([ba6405d](ba6405d)), closes [#593](#593) [#592](#592) * Filter dashboard scatter plot by PR states ([#736](#736)) ([f04093a](f04093a)) * handle close modal when click outside and improve select usage ([#705](#705)) ([105a47b](105a47b)), closes [#689](#689) * update icon PR details row ([#706](#706)) ([dac42ba](dac42ba)), closes [#696](#696)

github-actions · 2023-01-05T22:05:59Z

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

* origin/main: (29 commits) chore(minor): release 1.23.0 [skip ci] chore(minor): release 1.23.0-beta.13 on beta channel [skip ci] feat: update icon PR details row (#706) chore(patch): release 1.23.0-beta.12 on beta channel [skip ci] fix: only pull insights for stacked avatar on insight pages (#761) chore(patch): release 1.23.0-beta.11 on beta channel [skip ci] refactor: update pr velocity indicator (#707) chore(minor): release 1.23.0-beta.10 on beta channel [skip ci] feat: add hover card and expand on contributor stack (#742) chore(patch): release 1.23.0-beta.9 on beta channel [skip ci] fix: user profile auth avatar processing errors (#755) chore(minor): release 1.23.0-beta.8 on beta channel [skip ci] feat: handle close modal when click outside and improve select usage (#705) chore(patch): release 1.23.0-beta.7 on beta channel [skip ci] fix: correct some tooling and dependency issues (#749) chore(minor): release 1.23.0-beta.6 on beta channel [skip ci] fix: add missing title props feat: add Edit Page button to insight pages (#738) feat: enable repository selection & add to new insights page (#693) chore(minor): release 1.23.0-beta.5 on beta channel [skip ci] ...

## [1.23.0-beta.6](open-sauced/app@v1.23.0-beta.5...v1.23.0-beta.6) (2023-01-03) ### 🍕 Features * add Edit Page button to insight pages ([#738](open-sauced/app#738)) ([bde1eb8](open-sauced/app@bde1eb8)), closes [#685](open-sauced/app#685) * enable repository selection & add to new insights page ([#693](open-sauced/app#693)) ([ba6405d](open-sauced/app@ba6405d)), closes [#593](open-sauced/app#593) [#592](open-sauced/app#592) ### 🐛 Bug Fixes * add missing title props ([cdcc28d](open-sauced/app@cdcc28d))

## [1.23.0](open-sauced/app@v1.22.2...v1.23.0) (2023-01-05) ### 🧑‍💻 Code Refactoring * update pr velocity indicator ([#707](open-sauced/app#707)) ([7e96735](open-sauced/app@7e96735)), closes [#684](open-sauced/app#684) ### 🐛 Bug Fixes * add missing title props ([cdcc28d](open-sauced/app@cdcc28d)) * correct some tooling and dependency issues ([#749](open-sauced/app#749)) ([cb4ec9f](open-sauced/app@cb4ec9f)) * only pull insights for stacked avatar on insight pages ([#761](open-sauced/app#761)) ([80ae119](open-sauced/app@80ae119)) * overflow x bug on dashboard ([#709](open-sauced/app#709)) ([b022dbc](open-sauced/app@b022dbc)), closes [#677](open-sauced/app#677) * user profile auth avatar processing errors ([#755](open-sauced/app#755)) ([3ba87a6](open-sauced/app@3ba87a6)), closes [#733](open-sauced/app#733) ### 🍕 Features * add Edit Page button to insight pages ([#738](open-sauced/app#738)) ([bde1eb8](open-sauced/app@bde1eb8)), closes [#685](open-sauced/app#685) * add favorite repos on the design system ([#744](open-sauced/app#744)) ([c8660b5](open-sauced/app@c8660b5)), closes [#717](open-sauced/app#717) * add hover card and expand on contributor stack ([#742](open-sauced/app#742)) ([9f45b3d](open-sauced/app@9f45b3d)) * adjust search font-size ([c451450](open-sauced/app@c451450)) * change name to enhace from logarithmic ([#743](open-sauced/app#743)) ([4384324](open-sauced/app@4384324)) * enable repository selection & add to new insights page ([#693](open-sauced/app#693)) ([ba6405d](open-sauced/app@ba6405d)), closes [#593](open-sauced/app#593) [#592](open-sauced/app#592) * Filter dashboard scatter plot by PR states ([#736](open-sauced/app#736)) ([f04093a](open-sauced/app@f04093a)) * handle close modal when click outside and improve select usage ([#705](open-sauced/app#705)) ([105a47b](open-sauced/app@105a47b)), closes [#689](open-sauced/app#689) * update icon PR details row ([#706](open-sauced/app#706)) ([dac42ba](open-sauced/app@dac42ba)), closes [#696](open-sauced/app#696)

nightknighto added 2 commits December 25, 2022 21:26

feat: add Edit Page button to insight pages

45169d5

feat: improve mobile view

bdcafcb

nightknighto linked an issue Dec 25, 2022 that may be closed by this pull request

Feature: Edit button on insight pages #685

Closed

2 tasks

bdougie requested changes Dec 26, 2022

View reviewed changes

feat: only show Edit for owners

5ed66f0

nightknighto requested a review from bdougie December 26, 2022 18:58

bdougie approved these changes Dec 26, 2022

View reviewed changes

NsdHSO reviewed Dec 27, 2022

View reviewed changes

components/molecules/InsightHeader/insight-header.tsx Show resolved Hide resolved

NsdHSO reviewed Dec 27, 2022

View reviewed changes

brandonroberts requested changes Dec 28, 2022

View reviewed changes

layouts/hub-page.tsx Outdated Show resolved Hide resolved

components/molecules/InsightHeader/insight-header.tsx Outdated Show resolved Hide resolved

brandonroberts added the requested changes label Dec 28, 2022

bdougie added requested changes and removed requested changes labels Dec 28, 2022

nightknighto and others added 2 commits December 28, 2022 18:49

fix: use sub instead of provider_id

b23f0a4

Co-authored-by: Brandon <robertsbt@gmail.com>

refractor: re-order imports

2f27f43

brandonroberts approved these changes Dec 28, 2022

View reviewed changes

0-vortex suggested changes Dec 28, 2022

View reviewed changes

layouts/hub-page.tsx Outdated Show resolved Hide resolved

layouts/hub-page.tsx Outdated Show resolved Hide resolved

nightknighto changed the base branch from beta to save-to-dashboard December 28, 2022 19:22

nightknighto changed the base branch from save-to-dashboard to beta December 28, 2022 19:23

feat: add userId to useSupabaseAuth hook

4fee935

NsdHSO reviewed Dec 28, 2022

View reviewed changes

lib/hooks/useSupabaseAuth.ts Outdated Show resolved Hide resolved

nightknighto added 2 commits December 28, 2022 22:37

refractor: remove unneeded hard typing

014ac1c

refractor: use userId instead

a3cc932

nightknighto added 2 commits December 29, 2022 23:42

fix: revert default to null

2aa1c91

feat: error handling

5144384

lint

f3ab274

This was referenced Dec 31, 2022

Feature: Design a Loading component to be used in components waiting for data #751

Closed

Feature: Design an Error component to be used in components in which an error occurs #752

Closed

refractor: convert both to string insteadof number

2174c92

brandonroberts merged commit bde1eb8 into beta Jan 3, 2023

brandonroberts deleted the 685-feature-edit-button-on-insight-pages branch January 3, 2023 14:38

github-actions bot added the released label Jan 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Edit Page button to insight pages #738

feat: add Edit Page button to insight pages #738

nightknighto commented Dec 25, 2022

netlify bot commented Dec 25, 2022 •

edited

Loading

netlify bot commented Dec 25, 2022 •

edited

Loading

bdougie left a comment

bdougie left a comment

NsdHSO left a comment

0-vortex left a comment

nightknighto commented Dec 28, 2022

0-vortex commented Dec 28, 2022

brandonroberts commented Dec 29, 2022

github-actions bot commented Jan 5, 2023

feat: add Edit Page button to insight pages #738

feat: add Edit Page button to insight pages #738

Conversation

nightknighto commented Dec 25, 2022

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Dec 25, 2022 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Dec 25, 2022 • edited Loading

✅ Deploy Preview for design-insights ready!

bdougie left a comment

Choose a reason for hiding this comment

bdougie left a comment

Choose a reason for hiding this comment

NsdHSO left a comment

Choose a reason for hiding this comment

0-vortex left a comment

Choose a reason for hiding this comment

nightknighto commented Dec 28, 2022

0-vortex commented Dec 28, 2022

brandonroberts commented Dec 29, 2022

github-actions bot commented Jan 5, 2023

netlify bot commented Dec 25, 2022 •

edited

Loading

netlify bot commented Dec 25, 2022 •

edited

Loading