Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Save to dashboard feature #593

Closed
1 of 13 tasks
bdougie opened this issue Nov 14, 2022 · 5 comments · Fixed by #693
Closed
1 of 13 tasks

feature: Save to dashboard feature #593

bdougie opened this issue Nov 14, 2022 · 5 comments · Fixed by #693
Assignees
@nightknighto
Labels
💡 feature 👀 needs triage released
Milestone
Papercuts

Comments

@bdougie
Copy link
Member

bdougie commented Nov 14, 2022 •
edited
Loading

image

Type of feature

Select the type of feature request, the lowercase should also be the PR prefix.

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Current behavior

When viewing the insights dashboard, a user should be able to click on a repo page to see more details. Currently, we only show the repo tab, but it would be good to get custom page insights

Suggested solution

We should nudge the user to create a custom dashboard by doing the following.

  1. Sign in
  2. Select a repo from the table or save to dashboard button

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

Contributing Docs

If you plan on contributing code please read - Contribution Guide

  • I agree to follow this project's Contribution Docs

related #592
@bdougie bdougie added 💡 feature needs design Front-end tasks that are missing a design. Create a new issue for the design. 👀 needs triage labels Nov 14, 2022
@bdougie bdougie added this to the Design Sprint milestone Nov 14, 2022
@eryc-cc
Copy link
Contributor

eryc-cc commented Nov 29, 2022

Instead of clicking to filter on the Repository row, you get options to filter the data by the repo, or add to an Insight Page.

Select up to 10 repositories. It'll show up on a side/bottom sheet.

@bdougie bdougie mentioned this issue Dec 12, 2022
Closed
6 tasks
@bdougie
Copy link
Member Author

bdougie commented Dec 12, 2022 •
edited
Loading

This design was started here:
https://app.campsite.design/opensauced?postId=8ncqw0qs6aq0&fileId=oxzfi4pbjlje

https://www.figma.com/file/OpVX6WT7dmWqnwRuEvADMF/OpenSauced-%E2%80%94-Insights-(insights.opensauced.pizza)?node-id=5203%3A5431&t=lkqXy9mN3qvx546m-0

@bdougie bdougie removed the needs design Front-end tasks that are missing a design. Create a new issue for the design. label Dec 12, 2022
@bdougie bdougie modified the milestones: Design Sprint, Papercuts Dec 16, 2022
@bdougie
Copy link
Member Author

bdougie commented Dec 16, 2022 •
edited
Loading

Screen Shot 2022-12-16 at 11 31 39 AM

filter selected

Currently, users can click the repo name to filter for a single repo. It applies a filter to the URL for the user. Link example below.

https://beta.insights.opensauced.pizza/javascript/repositories/filter/i18next/i18next

Add to Insights Page

This should send the user to the "create insights" page with the repos selected added to the shopping cart.

Screen Shot 2022-12-16 at 11 35 23 AM

@bdougie bdougie moved this to In Progress in OpenSauced Operational Roadmap Dec 19, 2022
@nightknighto
Copy link
Contributor

@bdougie so how will the "Filter selected repositories" button work with multiple selections? Or do you just want the "Add to insight page" button?

@nightknighto nightknighto mentioned this issue Dec 20, 2022
Merged
19 tasks
brandonroberts pushed a commit that referenced this issue Jan 3, 2023
@nightknighto
feat: enable repository selection & add to new insights page (#693)
ba6405d 
fixes #593
fixes #592
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenSauced Operational Roadmap Jan 3, 2023
github-actions bot pushed a commit that referenced this issue Jan 3, 2023
@brandonroberts @open-sauced
chore(minor): release 1.23.0-beta.6 on beta channel [skip ci]
241bcbd 
## [1.23.0-beta.6](v1.23.0-beta.5...v1.23.0-beta.6) (2023-01-03)

### 🍕 Features

* add Edit Page button to insight pages ([#738](#738)) ([bde1eb8](bde1eb8)), closes [#685](#685)
* enable repository selection & add to new insights page ([#693](#693)) ([ba6405d](ba6405d)), closes [#593](#593) [#592](#592)

### 🐛 Bug Fixes

* add missing title props ([cdcc28d](cdcc28d))
github-actions bot pushed a commit that referenced this issue Jan 5, 2023
@0-vortex @open-sauced
chore(minor): release 1.23.0 [skip ci]
359c26c 
## [1.23.0](v1.22.2...v1.23.0) (2023-01-05)

### 🧑‍💻 Code Refactoring

* update pr velocity indicator ([#707](#707)) ([7e96735](7e96735)), closes [#684](#684)

### 🐛 Bug Fixes

* add missing title props ([cdcc28d](cdcc28d))
* correct some tooling and dependency issues ([#749](#749)) ([cb4ec9f](cb4ec9f))
* only pull insights for stacked avatar on insight pages ([#761](#761)) ([80ae119](80ae119))
* overflow x bug on dashboard ([#709](#709)) ([b022dbc](b022dbc)), closes [#677](#677)
* user profile auth avatar processing errors ([#755](#755)) ([3ba87a6](3ba87a6)), closes [#733](#733)

### 🍕 Features

* add Edit Page button to insight pages ([#738](#738)) ([bde1eb8](bde1eb8)), closes [#685](#685)
* add favorite repos on the design system ([#744](#744)) ([c8660b5](c8660b5)), closes [#717](#717)
* add hover card and expand on contributor stack ([#742](#742)) ([9f45b3d](9f45b3d))
* adjust search font-size ([c451450](c451450))
* change name to enhace from logarithmic ([#743](#743)) ([4384324](4384324))
* enable repository selection & add to new insights page ([#693](#693)) ([ba6405d](ba6405d)), closes [#593](#593) [#592](#592)
* Filter dashboard scatter plot by PR states ([#736](#736)) ([f04093a](f04093a))
* handle close modal when click outside and improve select usage ([#705](#705)) ([105a47b](105a47b)), closes [#689](#689)
* update icon PR  details row ([#706](#706)) ([dac42ba](dac42ba)), closes [#696](#696)
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

🎉 This issue has been resolved in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.23.0-beta.6 on beta channel [skip ci]
962bf45 
## [1.23.0-beta.6](open-sauced/app@v1.23.0-beta.5...v1.23.0-beta.6) (2023-01-03)

### 🍕 Features

* add Edit Page button to insight pages ([#738](open-sauced/app#738)) ([bde1eb8](open-sauced/app@bde1eb8)), closes [#685](open-sauced/app#685)
* enable repository selection & add to new insights page ([#693](open-sauced/app#693)) ([ba6405d](open-sauced/app@ba6405d)), closes [#593](open-sauced/app#593) [#592](open-sauced/app#592)

### 🐛 Bug Fixes

* add missing title props ([cdcc28d](open-sauced/app@cdcc28d))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.23.0 [skip ci]
b9e16b2 
## [1.23.0](open-sauced/app@v1.22.2...v1.23.0) (2023-01-05)

### 🧑‍💻 Code Refactoring

* update pr velocity indicator ([#707](open-sauced/app#707)) ([7e96735](open-sauced/app@7e96735)), closes [#684](open-sauced/app#684)

### 🐛 Bug Fixes

* add missing title props ([cdcc28d](open-sauced/app@cdcc28d))
* correct some tooling and dependency issues ([#749](open-sauced/app#749)) ([cb4ec9f](open-sauced/app@cb4ec9f))
* only pull insights for stacked avatar on insight pages ([#761](open-sauced/app#761)) ([80ae119](open-sauced/app@80ae119))
* overflow x bug on dashboard ([#709](open-sauced/app#709)) ([b022dbc](open-sauced/app@b022dbc)), closes [#677](open-sauced/app#677)
* user profile auth avatar processing errors ([#755](open-sauced/app#755)) ([3ba87a6](open-sauced/app@3ba87a6)), closes [#733](open-sauced/app#733)

### 🍕 Features

* add Edit Page button to insight pages ([#738](open-sauced/app#738)) ([bde1eb8](open-sauced/app@bde1eb8)), closes [#685](open-sauced/app#685)
* add favorite repos on the design system ([#744](open-sauced/app#744)) ([c8660b5](open-sauced/app@c8660b5)), closes [#717](open-sauced/app#717)
* add hover card and expand on contributor stack ([#742](open-sauced/app#742)) ([9f45b3d](open-sauced/app@9f45b3d))
* adjust search font-size ([c451450](open-sauced/app@c451450))
* change name to enhace from logarithmic ([#743](open-sauced/app#743)) ([4384324](open-sauced/app@4384324))
* enable repository selection & add to new insights page ([#693](open-sauced/app#693)) ([ba6405d](open-sauced/app@ba6405d)), closes [#593](open-sauced/app#593) [#592](open-sauced/app#592)
* Filter dashboard scatter plot by PR states ([#736](open-sauced/app#736)) ([f04093a](open-sauced/app@f04093a))
* handle close modal when click outside and improve select usage ([#705](open-sauced/app#705)) ([105a47b](open-sauced/app@105a47b)), closes [#689](open-sauced/app#689)
* update icon PR  details row ([#706](open-sauced/app#706)) ([dac42ba](open-sauced/app@dac42ba)), closes [#696](open-sauced/app#696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nightknighto nightknighto

Labels
💡 feature 👀 needs triage released
Projects
No open projects
OpenSauced Operational Roadmap
Status: Done
Milestone
Papercuts
Development

Successfully merging a pull request may close this issue.

feat: repository selection & add to insights open-sauced/app
3 participants
@bdougie @nightknighto @eryc-cc