-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update icon PR details row #706
Conversation
β Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@sungoldtech, looking at the OP mock and I think we should remove icons and percents altogether. They are not adding value. Please update the exact copy.
PRs reviewed are not possible right now. |
The data received from the API call for the Question:
cc: @bdougie |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes needed, but LGTM! π
components/organisms/ContributorProfilePage/contributor-profile-page.tsx
Outdated
Show resolved
Hide resolved
@OgDev-01 this one needs merge conflicts to be resolved also |
π This PR is included in version 1.23.0-beta.13 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.23.0](v1.22.2...v1.23.0) (2023-01-05) ### π§βπ» Code Refactoring * update pr velocity indicator ([#707](#707)) ([7e96735](7e96735)), closes [#684](#684) ### π Bug Fixes * add missing title props ([cdcc28d](cdcc28d)) * correct some tooling and dependency issues ([#749](#749)) ([cb4ec9f](cb4ec9f)) * only pull insights for stacked avatar on insight pages ([#761](#761)) ([80ae119](80ae119)) * overflow x bug on dashboard ([#709](#709)) ([b022dbc](b022dbc)), closes [#677](#677) * user profile auth avatar processing errors ([#755](#755)) ([3ba87a6](3ba87a6)), closes [#733](#733) ### π Features * add Edit Page button to insight pages ([#738](#738)) ([bde1eb8](bde1eb8)), closes [#685](#685) * add favorite repos on the design system ([#744](#744)) ([c8660b5](c8660b5)), closes [#717](#717) * add hover card and expand on contributor stack ([#742](#742)) ([9f45b3d](9f45b3d)) * adjust search font-size ([c451450](c451450)) * change name to enhace from logarithmic ([#743](#743)) ([4384324](4384324)) * enable repository selection & add to new insights page ([#693](#693)) ([ba6405d](ba6405d)), closes [#593](#593) [#592](#592) * Filter dashboard scatter plot by PR states ([#736](#736)) ([f04093a](f04093a)) * handle close modal when click outside and improve select usage ([#705](#705)) ([105a47b](105a47b)), closes [#689](#689) * update icon PR details row ([#706](#706)) ([dac42ba](dac42ba)), closes [#696](#696)
π This PR is included in version 1.23.0 π The release is available on GitHub release Your semantic-release bot π¦π |
* origin/main: (29 commits) chore(minor): release 1.23.0 [skip ci] chore(minor): release 1.23.0-beta.13 on beta channel [skip ci] feat: update icon PR details row (#706) chore(patch): release 1.23.0-beta.12 on beta channel [skip ci] fix: only pull insights for stacked avatar on insight pages (#761) chore(patch): release 1.23.0-beta.11 on beta channel [skip ci] refactor: update pr velocity indicator (#707) chore(minor): release 1.23.0-beta.10 on beta channel [skip ci] feat: add hover card and expand on contributor stack (#742) chore(patch): release 1.23.0-beta.9 on beta channel [skip ci] fix: user profile auth avatar processing errors (#755) chore(minor): release 1.23.0-beta.8 on beta channel [skip ci] feat: handle close modal when click outside and improve select usage (#705) chore(patch): release 1.23.0-beta.7 on beta channel [skip ci] fix: correct some tooling and dependency issues (#749) chore(minor): release 1.23.0-beta.6 on beta channel [skip ci] fix: add missing title props feat: add Edit Page button to insight pages (#738) feat: enable repository selection & add to new insights page (#693) chore(minor): release 1.23.0-beta.5 on beta channel [skip ci] ...
## [1.23.0-beta.13](open-sauced/app@v1.23.0-beta.12...v1.23.0-beta.13) (2023-01-05) ### π Features * update icon PR details row ([#706](open-sauced/app#706)) ([dac42ba](open-sauced/app@dac42ba)), closes [#696](open-sauced/app#696)
## [1.23.0](open-sauced/app@v1.22.2...v1.23.0) (2023-01-05) ### π§βπ» Code Refactoring * update pr velocity indicator ([#707](open-sauced/app#707)) ([7e96735](open-sauced/app@7e96735)), closes [#684](open-sauced/app#684) ### π Bug Fixes * add missing title props ([cdcc28d](open-sauced/app@cdcc28d)) * correct some tooling and dependency issues ([#749](open-sauced/app#749)) ([cb4ec9f](open-sauced/app@cb4ec9f)) * only pull insights for stacked avatar on insight pages ([#761](open-sauced/app#761)) ([80ae119](open-sauced/app@80ae119)) * overflow x bug on dashboard ([#709](open-sauced/app#709)) ([b022dbc](open-sauced/app@b022dbc)), closes [#677](open-sauced/app#677) * user profile auth avatar processing errors ([#755](open-sauced/app#755)) ([3ba87a6](open-sauced/app@3ba87a6)), closes [#733](open-sauced/app#733) ### π Features * add Edit Page button to insight pages ([#738](open-sauced/app#738)) ([bde1eb8](open-sauced/app@bde1eb8)), closes [#685](open-sauced/app#685) * add favorite repos on the design system ([#744](open-sauced/app#744)) ([c8660b5](open-sauced/app@c8660b5)), closes [#717](open-sauced/app#717) * add hover card and expand on contributor stack ([#742](open-sauced/app#742)) ([9f45b3d](open-sauced/app@9f45b3d)) * adjust search font-size ([c451450](open-sauced/app@c451450)) * change name to enhace from logarithmic ([#743](open-sauced/app#743)) ([4384324](open-sauced/app@4384324)) * enable repository selection & add to new insights page ([#693](open-sauced/app#693)) ([ba6405d](open-sauced/app@ba6405d)), closes [#593](open-sauced/app#593) [#592](open-sauced/app#592) * Filter dashboard scatter plot by PR states ([#736](open-sauced/app#736)) ([f04093a](open-sauced/app@f04093a)) * handle close modal when click outside and improve select usage ([#705](open-sauced/app#705)) ([105a47b](open-sauced/app@105a47b)), closes [#689](open-sauced/app#689) * update icon PR details row ([#706](open-sauced/app#706)) ([dac42ba](open-sauced/app@dac42ba)), closes [#696](open-sauced/app#696)
What type of PR is this? (check all applicable)
Description
This PR:
DbContribution
types with extra values from the apiNotes:
The Open PRs percentage is still static and will be updated in a follow-up PR as it depend's on updates from the API
cc: @brandonroberts
Related Tickets & Documents
Fixes #696
Mobile & Desktop Screenshots/Recordings
Mobile
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?