Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update icon PR details row #706

Merged
merged 14 commits into from
Jan 5, 2023
Merged

feat: update icon PR details row #706

merged 14 commits into from
Jan 5, 2023

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Dec 22, 2022

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR:

  • Updates the contributors profile page to include PRs related data
  • Updates global DbContribution types with extra values from the api

Notes:

The Open PRs percentage is still static and will be updated in a follow-up PR as it depend's on updates from the API
cc: @brandonroberts

Related Tickets & Documents

Fixes #696

Mobile & Desktop Screenshots/Recordings

image

Mobile

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Dec 22, 2022

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit f7b3f43
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/63b72d6971527c00088065ee
😎 Deploy Preview https://deploy-preview-706--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 22, 2022

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit f7b3f43
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/63b72d69bff5900009777d49
😎 Deploy Preview https://deploy-preview-706--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OgDev-01 OgDev-01 changed the title 696 pr details row feat: update con PRs details row Dec 22, 2022
@OgDev-01 OgDev-01 changed the title feat: update con PRs details row feat: update con PR details row Dec 22, 2022
@OgDev-01 OgDev-01 marked this pull request as ready for review December 22, 2022 05:37
@bdougie
Copy link
Member

bdougie commented Dec 22, 2022

@sungoldtech, looking at the OP mock and I think we should remove icons and percents altogether. They are not adding value.

Please update the exact copy.

  • PRs Opened
  • PR Velocity
  • Contributed Repos

PRs reviewed are not possible right now.

Screen Shot 2022-12-22 at 5 59 08 AM

@OgDev-01
Copy link
Contributor Author

PRs reviewed are not possible right now.

The data received from the API call for the useSingleContributor hook reflects a recent_pr_reviews field in the return object...

Question:

  • Is the recent_pr_reviews field not meant for the Prs Reviewed path?

cc: @bdougie

@brandonroberts
Copy link
Contributor

The recent_pr_reviews is assigned reviews, not completed reviews. We can decide whether that's useful to show or not

Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes needed, but LGTM! πŸ‘

components/molecules/CardRepoList/card-repo-list.tsx Outdated Show resolved Hide resolved
pages/user/[username].tsx Outdated Show resolved Hide resolved
@brandonroberts brandonroberts changed the title feat: update con PR details row feat: update icon PR details row Dec 22, 2022
@brandonroberts
Copy link
Contributor

@OgDev-01 this one needs merge conflicts to be resolved also

@brandonroberts brandonroberts merged commit dac42ba into beta Jan 5, 2023
@brandonroberts brandonroberts deleted the 696-pr-details-row branch January 5, 2023 20:47
github-actions bot pushed a commit that referenced this pull request Jan 5, 2023
## [1.23.0-beta.13](v1.23.0-beta.12...v1.23.0-beta.13) (2023-01-05)

### πŸ• Features

* update icon PR  details row ([#706](#706)) ([dac42ba](dac42ba)), closes [#696](#696)
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

πŸŽ‰ This PR is included in version 1.23.0-beta.13 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jan 5, 2023
## [1.23.0](v1.22.2...v1.23.0) (2023-01-05)

### πŸ§‘β€πŸ’» Code Refactoring

* update pr velocity indicator ([#707](#707)) ([7e96735](7e96735)), closes [#684](#684)

### πŸ› Bug Fixes

* add missing title props ([cdcc28d](cdcc28d))
* correct some tooling and dependency issues ([#749](#749)) ([cb4ec9f](cb4ec9f))
* only pull insights for stacked avatar on insight pages ([#761](#761)) ([80ae119](80ae119))
* overflow x bug on dashboard ([#709](#709)) ([b022dbc](b022dbc)), closes [#677](#677)
* user profile auth avatar processing errors ([#755](#755)) ([3ba87a6](3ba87a6)), closes [#733](#733)

### πŸ• Features

* add Edit Page button to insight pages ([#738](#738)) ([bde1eb8](bde1eb8)), closes [#685](#685)
* add favorite repos on the design system ([#744](#744)) ([c8660b5](c8660b5)), closes [#717](#717)
* add hover card and expand on contributor stack ([#742](#742)) ([9f45b3d](9f45b3d))
* adjust search font-size ([c451450](c451450))
* change name to enhace from logarithmic ([#743](#743)) ([4384324](4384324))
* enable repository selection & add to new insights page ([#693](#693)) ([ba6405d](ba6405d)), closes [#593](#593) [#592](#592)
* Filter dashboard scatter plot by PR states ([#736](#736)) ([f04093a](f04093a))
* handle close modal when click outside and improve select usage ([#705](#705)) ([105a47b](105a47b)), closes [#689](#689)
* update icon PR  details row ([#706](#706)) ([dac42ba](dac42ba)), closes [#696](#696)
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

πŸŽ‰ This PR is included in version 1.23.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

0-vortex added a commit that referenced this pull request Jan 5, 2023
* origin/main: (29 commits)
  chore(minor): release 1.23.0 [skip ci]
  chore(minor): release 1.23.0-beta.13 on beta channel [skip ci]
  feat: update icon PR  details row (#706)
  chore(patch): release 1.23.0-beta.12 on beta channel [skip ci]
  fix: only pull insights for stacked avatar on insight pages (#761)
  chore(patch): release 1.23.0-beta.11 on beta channel [skip ci]
  refactor: update pr velocity indicator (#707)
  chore(minor): release 1.23.0-beta.10 on beta channel [skip ci]
  feat: add hover card and expand on contributor stack (#742)
  chore(patch): release 1.23.0-beta.9 on beta channel [skip ci]
  fix: user profile auth avatar processing errors (#755)
  chore(minor): release 1.23.0-beta.8 on beta channel [skip ci]
  feat: handle close modal when click outside and improve select usage (#705)
  chore(patch): release 1.23.0-beta.7 on beta channel [skip ci]
  fix: correct some tooling and dependency issues (#749)
  chore(minor): release 1.23.0-beta.6 on beta channel [skip ci]
  fix: add missing title props
  feat: add Edit Page button to insight pages (#738)
  feat: enable repository selection & add to new insights page (#693)
  chore(minor): release 1.23.0-beta.5 on beta channel [skip ci]
  ...
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.23.0-beta.13](open-sauced/app@v1.23.0-beta.12...v1.23.0-beta.13) (2023-01-05)

### πŸ• Features

* update icon PR  details row ([#706](open-sauced/app#706)) ([dac42ba](open-sauced/app@dac42ba)), closes [#696](open-sauced/app#696)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.23.0](open-sauced/app@v1.22.2...v1.23.0) (2023-01-05)

### πŸ§‘β€πŸ’» Code Refactoring

* update pr velocity indicator ([#707](open-sauced/app#707)) ([7e96735](open-sauced/app@7e96735)), closes [#684](open-sauced/app#684)

### πŸ› Bug Fixes

* add missing title props ([cdcc28d](open-sauced/app@cdcc28d))
* correct some tooling and dependency issues ([#749](open-sauced/app#749)) ([cb4ec9f](open-sauced/app@cb4ec9f))
* only pull insights for stacked avatar on insight pages ([#761](open-sauced/app#761)) ([80ae119](open-sauced/app@80ae119))
* overflow x bug on dashboard ([#709](open-sauced/app#709)) ([b022dbc](open-sauced/app@b022dbc)), closes [#677](open-sauced/app#677)
* user profile auth avatar processing errors ([#755](open-sauced/app#755)) ([3ba87a6](open-sauced/app@3ba87a6)), closes [#733](open-sauced/app#733)

### πŸ• Features

* add Edit Page button to insight pages ([#738](open-sauced/app#738)) ([bde1eb8](open-sauced/app@bde1eb8)), closes [#685](open-sauced/app#685)
* add favorite repos on the design system ([#744](open-sauced/app#744)) ([c8660b5](open-sauced/app@c8660b5)), closes [#717](open-sauced/app#717)
* add hover card and expand on contributor stack ([#742](open-sauced/app#742)) ([9f45b3d](open-sauced/app@9f45b3d))
* adjust search font-size ([c451450](open-sauced/app@c451450))
* change name to enhace from logarithmic ([#743](open-sauced/app#743)) ([4384324](open-sauced/app@4384324))
* enable repository selection & add to new insights page ([#693](open-sauced/app#693)) ([ba6405d](open-sauced/app@ba6405d)), closes [#593](open-sauced/app#593) [#592](open-sauced/app#592)
* Filter dashboard scatter plot by PR states ([#736](open-sauced/app#736)) ([f04093a](open-sauced/app@f04093a))
* handle close modal when click outside and improve select usage ([#705](open-sauced/app#705)) ([105a47b](open-sauced/app@105a47b)), closes [#689](open-sauced/app#689)
* update icon PR  details row ([#706](open-sauced/app#706)) ([dac42ba](open-sauced/app@dac42ba)), closes [#696](open-sauced/app#696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add PR details row data to generic profile page
4 participants