Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overflow x bug on dashboard #709

Merged

Conversation

payn33
Copy link
Contributor

@payn33 payn33 commented Dec 22, 2022

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

  • This pr fixes an overflow bug on the dashboard page by including an overflow: hidden property on the filter.tsx container

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Before

Open.Sauced.Insights.-.Javascript._.Dashboard.-.Google.Chrome.2022-12-22.10-22-48.mp4

After

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@netlify
Copy link

netlify bot commented Dec 22, 2022

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 1443af0
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/63a64a7cdc54d200087e1d1e
😎 Deploy Preview https://deploy-preview-709--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❀️! πŸŽ‰πŸ•
Say hello by joining the conversation in our Discord

@netlify
Copy link

netlify bot commented Dec 22, 2022

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 1443af0
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/63a64a7cb2ca59000950611c
😎 Deploy Preview https://deploy-preview-709--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nightknighto nightknighto requested a review from bdougie December 22, 2022 12:54
Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR, unfortunately we need some more information to be able to test this on our end! πŸ•

layouts/filter.tsx Outdated Show resolved Hide resolved
@payn33 payn33 requested a review from 0-vortex December 23, 2022 11:07
layouts/filter.tsx Show resolved Hide resolved
components/organisms/ToolList/nav.tsx Show resolved Hide resolved
@brandonroberts brandonroberts added the needs review PRs that need review from core engineering team label Dec 23, 2022
@brandonroberts brandonroberts merged commit b022dbc into open-sauced:beta Dec 28, 2022
github-actions bot pushed a commit that referenced this pull request Dec 28, 2022
## [1.23.0-beta.3](v1.23.0-beta.2...v1.23.0-beta.3) (2022-12-28)

### πŸ› Bug Fixes

* overflow x bug on dashboard ([#709](#709)) ([b022dbc](b022dbc)), closes [#677](#677)
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.23.0-beta.3 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jan 5, 2023
## [1.23.0](v1.22.2...v1.23.0) (2023-01-05)

### πŸ§‘β€πŸ’» Code Refactoring

* update pr velocity indicator ([#707](#707)) ([7e96735](7e96735)), closes [#684](#684)

### πŸ› Bug Fixes

* add missing title props ([cdcc28d](cdcc28d))
* correct some tooling and dependency issues ([#749](#749)) ([cb4ec9f](cb4ec9f))
* only pull insights for stacked avatar on insight pages ([#761](#761)) ([80ae119](80ae119))
* overflow x bug on dashboard ([#709](#709)) ([b022dbc](b022dbc)), closes [#677](#677)
* user profile auth avatar processing errors ([#755](#755)) ([3ba87a6](3ba87a6)), closes [#733](#733)

### πŸ• Features

* add Edit Page button to insight pages ([#738](#738)) ([bde1eb8](bde1eb8)), closes [#685](#685)
* add favorite repos on the design system ([#744](#744)) ([c8660b5](c8660b5)), closes [#717](#717)
* add hover card and expand on contributor stack ([#742](#742)) ([9f45b3d](9f45b3d))
* adjust search font-size ([c451450](c451450))
* change name to enhace from logarithmic ([#743](#743)) ([4384324](4384324))
* enable repository selection & add to new insights page ([#693](#693)) ([ba6405d](ba6405d)), closes [#593](#593) [#592](#592)
* Filter dashboard scatter plot by PR states ([#736](#736)) ([f04093a](f04093a))
* handle close modal when click outside and improve select usage ([#705](#705)) ([105a47b](105a47b)), closes [#689](#689)
* update icon PR  details row ([#706](#706)) ([dac42ba](dac42ba)), closes [#696](#696)
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

πŸŽ‰ This PR is included in version 1.23.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.23.0-beta.3](open-sauced/app@v1.23.0-beta.2...v1.23.0-beta.3) (2022-12-28)

### πŸ› Bug Fixes

* overflow x bug on dashboard ([#709](open-sauced/app#709)) ([b022dbc](open-sauced/app@b022dbc)), closes [#677](open-sauced/app#677)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.23.0](open-sauced/app@v1.22.2...v1.23.0) (2023-01-05)

### πŸ§‘β€πŸ’» Code Refactoring

* update pr velocity indicator ([#707](open-sauced/app#707)) ([7e96735](open-sauced/app@7e96735)), closes [#684](open-sauced/app#684)

### πŸ› Bug Fixes

* add missing title props ([cdcc28d](open-sauced/app@cdcc28d))
* correct some tooling and dependency issues ([#749](open-sauced/app#749)) ([cb4ec9f](open-sauced/app@cb4ec9f))
* only pull insights for stacked avatar on insight pages ([#761](open-sauced/app#761)) ([80ae119](open-sauced/app@80ae119))
* overflow x bug on dashboard ([#709](open-sauced/app#709)) ([b022dbc](open-sauced/app@b022dbc)), closes [#677](open-sauced/app#677)
* user profile auth avatar processing errors ([#755](open-sauced/app#755)) ([3ba87a6](open-sauced/app@3ba87a6)), closes [#733](open-sauced/app#733)

### πŸ• Features

* add Edit Page button to insight pages ([#738](open-sauced/app#738)) ([bde1eb8](open-sauced/app@bde1eb8)), closes [#685](open-sauced/app#685)
* add favorite repos on the design system ([#744](open-sauced/app#744)) ([c8660b5](open-sauced/app@c8660b5)), closes [#717](open-sauced/app#717)
* add hover card and expand on contributor stack ([#742](open-sauced/app#742)) ([9f45b3d](open-sauced/app@9f45b3d))
* adjust search font-size ([c451450](open-sauced/app@c451450))
* change name to enhace from logarithmic ([#743](open-sauced/app#743)) ([4384324](open-sauced/app@4384324))
* enable repository selection & add to new insights page ([#693](open-sauced/app#693)) ([ba6405d](open-sauced/app@ba6405d)), closes [#593](open-sauced/app#593) [#592](open-sauced/app#592)
* Filter dashboard scatter plot by PR states ([#736](open-sauced/app#736)) ([f04093a](open-sauced/app@f04093a))
* handle close modal when click outside and improve select usage ([#705](open-sauced/app#705)) ([105a47b](open-sauced/app@105a47b)), closes [#689](open-sauced/app#689)
* update icon PR  details row ([#706](open-sauced/app#706)) ([dac42ba](open-sauced/app@dac42ba)), closes [#696](open-sauced/app#696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PRs that need review from core engineering team released on @beta released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: overflow-x on the insights page
4 participants