Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination to contributors page #454

Merged
merged 6 commits into from
Sep 28, 2022

Conversation

OgDev-01
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR adds pagination to the contributors page

Related Tickets & Documents

#403

Mobile & Desktop Screenshots/Recordings

Desktop
image

Mobile
image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 28, 2022

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit b746462
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6334b3bc6639c90008bbfd7d
😎 Deploy Preview https://deploy-preview-454--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@netlify
Copy link

netlify bot commented Sep 28, 2022

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit b746462
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6334b3bc865bd60009cd9667
😎 Deploy Preview https://deploy-preview-454--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Small change and please format the file

components/organisms/Contributors/contributors.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

@brandonroberts brandonroberts merged commit 37f4da8 into beta Sep 28, 2022
@brandonroberts brandonroberts deleted the 403-contributors-pagination branch September 28, 2022 22:43
github-actions bot pushed a commit that referenced this pull request Sep 28, 2022
## [1.8.0-beta.2](v1.8.0-beta.1...v1.8.0-beta.2) (2022-09-28)

### πŸ• Features

* add pagination to contributors page ([#454](#454)) ([37f4da8](37f4da8)), closes [#403](#403)
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.8.0-beta.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Oct 3, 2022
## [1.9.0](v1.8.0...v1.9.0) (2022-10-03)

### πŸ› Bug Fixes

* add truncate to contributors repositories list tab ([#472](#472)) ([b7ec96e](b7ec96e)), closes [#460](#460)
* fix merged PRs that looks like closed  ([#475](#475)) ([1dd820a](1dd820a)), closes [#462](#462)
* issue template πŸ‘‹πŸΎ ([31b7a7e](31b7a7e))
* moved page head and footer to repo page to avoid reloading the entire screen ([#473](#473)) ([bf790e8](bf790e8)), closes [#449](#449)
* replace churn with overview ([#470](#470)) ([fc0fe3f](fc0fe3f)), closes [#469](#469)
* SEO descriptions ([980e01d](980e01d))

### πŸ• Features

* add filters to hooks for repos and contributions ([#458](#458)) ([05e6bbe](05e6bbe)), closes [#457](#457)
* add page title and info to repo and contributors page ([#459](#459)) ([c0000e4](c0000e4)), closes [#446](#446)
* add pagination to contributors page ([#454](#454)) ([37f4da8](37f4da8)), closes [#403](#403)
* Add swr cache ([#437](#437)) ([6b2b1cb](6b2b1cb)), closes [#308](#308)
* connect scatter chart to contributors data ([#466](#466)) ([be78024](be78024)), closes [#465](#465)
* hide show/hide buttons temporarily ([#474](#474)) ([2ce5b3c](2ce5b3c)), closes [#439](#439)
* Leverage cloudinary for round images ([#467](#467)) ([7dc64d8](7dc64d8)), closes [#373](#373)
* update filters for repos and contributors ([#464](#464)) ([e15bbf8](e15bbf8)), closes [#461](#461)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.8.0-beta.2](open-sauced/app@v1.8.0-beta.1...v1.8.0-beta.2) (2022-09-28)

### πŸ• Features

* add pagination to contributors page ([#454](open-sauced/app#454)) ([37f4da8](open-sauced/app@37f4da8)), closes [#403](open-sauced/app#403)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.9.0](open-sauced/app@v1.8.0...v1.9.0) (2022-10-03)

### πŸ› Bug Fixes

* add truncate to contributors repositories list tab ([#472](open-sauced/app#472)) ([b7ec96e](open-sauced/app@b7ec96e)), closes [#460](open-sauced/app#460)
* fix merged PRs that looks like closed  ([#475](open-sauced/app#475)) ([1dd820a](open-sauced/app@1dd820a)), closes [#462](open-sauced/app#462)
* issue template πŸ‘‹πŸΎ ([31b7a7e](open-sauced/app@31b7a7e))
* moved page head and footer to repo page to avoid reloading the entire screen ([#473](open-sauced/app#473)) ([bf790e8](open-sauced/app@bf790e8)), closes [#449](open-sauced/app#449)
* replace churn with overview ([#470](open-sauced/app#470)) ([fc0fe3f](open-sauced/app@fc0fe3f)), closes [#469](open-sauced/app#469)
* SEO descriptions ([980e01d](open-sauced/app@980e01d))

### πŸ• Features

* add filters to hooks for repos and contributions ([#458](open-sauced/app#458)) ([05e6bbe](open-sauced/app@05e6bbe)), closes [#457](open-sauced/app#457)
* add page title and info to repo and contributors page ([#459](open-sauced/app#459)) ([c0000e4](open-sauced/app@c0000e4)), closes [#446](open-sauced/app#446)
* add pagination to contributors page ([#454](open-sauced/app#454)) ([37f4da8](open-sauced/app@37f4da8)), closes [#403](open-sauced/app#403)
* Add swr cache ([#437](open-sauced/app#437)) ([6b2b1cb](open-sauced/app@6b2b1cb)), closes [#308](open-sauced/app#308)
* connect scatter chart to contributors data ([#466](open-sauced/app#466)) ([be78024](open-sauced/app@be78024)), closes [#465](open-sauced/app#465)
* hide show/hide buttons temporarily ([#474](open-sauced/app#474)) ([2ce5b3c](open-sauced/app@2ce5b3c)), closes [#439](open-sauced/app#439)
* Leverage cloudinary for round images ([#467](open-sauced/app#467)) ([7dc64d8](open-sauced/app@7dc64d8)), closes [#373](open-sauced/app#373)
* update filters for repos and contributors ([#464](open-sauced/app#464)) ([e15bbf8](open-sauced/app@e15bbf8)), closes [#461](open-sauced/app#461)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants