This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
fix(vite.config.ts): fix font loading bug #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug still seems to be present in my local host, but pushing for extras eyes on my code. fix #243
✅ Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
0-vortex
reviewed
Aug 5, 2022
vite.config.ts
Outdated
| @@ -64,8 +64,8 @@ export default defineConfig(({command, mode}: ConfigEnv): UserConfig => { | |||
| display: 'swap', | |||
| injectTo: 'head-prepend', | |||
| families: [ | |||
| 'Inter:100,200,300,400,500,600,700,800,900', | |||
| 'Lexend:100,200,300,400,500,600,700,800,900' | |||
| 'Inter:wght@100,200,300,400,500,600,700,800,900', | |||
There was a problem hiding this comment.
This should fix it on the deploy preview as well, it was ; instead of ,:
'Inter:wght@400;600;900',
'Lexend:wght@400;600;900'
There was a problem hiding this comment.
I would go with this solution rather than mine 😎
bdougie
reviewed
Aug 5, 2022
vite.config.ts
Outdated
Comment on lines
67
to
68
| 'Inter:wght@100,200,300,400,500,600,700,800,900', | ||
| 'Lexend:wght@100,200,300,400,500,600,700,800,900' |
There was a problem hiding this comment.
Suggested change
| 'Inter:wght@100,200,300,400,500,600,700,800,900', | |
| 'Lexend:wght@100,200,300,400,500,600,700,800,900' | |
| // families can be either strings (only regular 400 will be loaded) | |
| 'Lexend', | |
| // or objects | |
| { | |
| /** | |
| * Family name (required) | |
| */ | |
| name: 'Inter', | |
| /** | |
| * Family styles | |
| */ | |
| styles: 'ital,wght@0,400;1,200', | |
| /** | |
| * enable non-blocking renderer | |
| * <link rel="preload" href="xxx" as="style" onload="this.rel='stylesheet'"> | |
| * default: true | |
| */ | |
| defer: true, | |
| }, |
So after looking at the project README, this will work. It loads only the 400 or regular version of Lexend, and multiple versions of Inter.
|
|
Was just posting a screenshot myself, congrats! Merging this in now 🍕 🚀 |
|
🎉 This PR is included in version 2.21.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
0-vortex
added a commit
that referenced
this pull request
Aug 11, 2022
* origin/main: (117 commits) chore(patch): release 2.23.3 [skip ci] fix: correct swr fetcher not throwing on error (#306) chore(patch): release 2.23.2 [skip ci] fix: load more doesn't load repositories (#304) chore(patch): release 2.23.1 [skip ci] fix: dedupe app global user state (#303) chore(minor): release 2.23.0 [skip ci] feat: change title font to open sans bold (#300) chore(minor): release 2.22.0 [skip ci] feat: updated css to respect row in subnav (#298) feat: use async hooks and beta api for hot repos (#296) chore(patch): release 2.21.2 [skip ci] fix(vite.config.ts): correct font loading preload (#294) chore(patch): release 2.21.1 [skip ci] fix: dedupe handleVoteUpdateByRepo function (#292) chore(minor): release 2.21.0 [skip ci] chore(minor): release 2.20.0 [skip ci] feat: make the contributors StackedAvatars component reusable (#290) chore(minor): release 2.19.0 [skip ci] feat: added system notification (#285) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug still seems to be present in my local host, but pushing for extras eyes on my code.
fix #243
What type of PR is this? (check all applicable)
Description
This PR fixes the font loading bug.
Related Tickets & Documents
Fixes #243
Mobile & Desktop Screenshots/Recordings
I don't see a change in my local host 😅
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
No I don't believe so.
[optional] What gif best describes this PR or how it makes you feel?
I know I'm completely supported and standing in like 5 inches of water, and yet... Life as a junior dev I suppose lol
