Bug: duplicate repositories can be added to dashboard #1219

git-srinivas · 2021-10-09T19:15:37Z

Describe the bug

When a user login to the app, there are see two sections on the dashboard. One is the repo recommendations list and the other is dashboard repo list.

Expected behaviour:
When user try to add a recommended repo item for one time or multiple times, it should be added to the dashboard repo list only once.

Actual behaviour:
When the user add a recommended repo item for multiple times, it gets added to the dashboard list for multipl times. Which is causing duplicate records of the same repo item in the dashboard list. Which is redundant and not expected.

Proposed solution:
We can keep a block loader or spinner on the recommended repo list, till the repo item disappers( or till the sync action completes)?

I am attaching a screenshot (from my mobile browser) below, which depicts the same

Steps to reproduce

1.Login to the app
2. Go to repository recommendation list
3. Click on add button continuously for 2 or more times
4. Reload the app and you can see duplicate repositories on the dashboard repo list

Affected services

opensauced.pizza

Platforms

Desktop, Mobile, Tablet

Browsers

Chrome

Environment

Production

Additional context

No response

Code of Conduct

I agree to follow this project's Code of Conduct

mtfoley · 2021-10-09T21:40:44Z

@git-srinivas thanks for filing this issue!

In my opinion, this is related to issue #832.

0-vortex · 2021-10-10T02:22:28Z

Cannot reproduce, could you provide additional instructions

git-srinivas · 2021-10-10T04:32:59Z

Go to repository recommendations
Click on add button for 2 or more times. Dont wait for 30 seconds or sync to complete
just click on add button continuously
Reload the app and you can see the duplicate repo records
Here is my data json that contains the same

0-vortex · 2021-10-10T08:45:17Z

What + symbol? Tried both desktop and mobile already before posting the cannot reproduce comment.

0-vortex · 2021-10-10T09:02:18Z

Managed to reproduce but only on desktop.

Duplicate repositories can be added to dashboard. As a user, if I added a repo as favorite. A single list item would be sufficient to track updates.

Understand this is a real issue now but In the future, could you kindly check with @open-sauced/triage before filing bugs with missing information? It helps us reduce the back and forth for a fix that could be a few lines of code!

git-srinivas · 2021-10-10T09:57:27Z

What + symbol? Tried both desktop and mobile already before posting the cannot reproduce comment.

It is add button in recommendations. I mentioned in the steps to reproduce. My wording could be much better

git-srinivas · 2021-10-10T10:06:29Z

Managed to reproduce but only on desktop.

Duplicate repositories can be added to dashboard. As a user, if I added a repo as favorite. A single list item would be sufficient to track updates.

Understand this is a real issue now but In the future, could you kindly check with @open-sauced/triage before filing bugs with missing information? It helps us reduce the back and forth for a fix that could be a few lines of code!

Since our app is a web application, the bug can be replicated in both desktop and mobile. I added the screen shot from my mobile browser only.

@0-vortex If you feel the bug is redundant, I can close this and update the triage bug?

0-vortex · 2021-10-10T10:16:08Z

Since our app is a web application, the bug can be replicated in both desktop and mobile. I added the screen shot from my mobile browser only.

Please stick to the topic - I understand the screenshot is from mobile, my question was whether or not you actually used the mobile platform to produce the bug.

@0-vortex If you feel the bug is redundant, I can close this and update the triage bug?

That is not helpful in any way, updating the issue with proper description and steps would be the way to go, especially if any of the triage team wants to take a look at this or a contributor is willing to pick it up.
If you do not plan to contribute to this issue, is better issue wording, rather than commenting, an unreasonable request?

git-srinivas · 2021-10-10T11:24:45Z

@0-vortex My apologies. This is the first bug i ever raised with open source projects/apps. Thanks for the guidance. I updated the bug description and steps to reproduce. Please check and let me know if it is fine :)

mtfoley · 2021-10-11T18:12:46Z

@git-srinivas Thanks again for submitting the issue. I think you've put enough information in here for contributors to know what to work on.

The PR you had already submitted #1215 helps with this issue somewhat, but only if the goals list is updated after adding a goal, so that the recommendations list can remove the goal. As I mentioned before, there are some bugs with the application's state getting updated correctly when adding/removing goals (as described in #832).

mtfoley · 2021-10-13T03:38:08Z

I got a chance to re-reproduce this tonight after #1220 landed - the situation is a little better since repo does get added in goals list when using + button in recommendations list. However, the recommendations list doesn’t repopulate with the newly added goal filtered out. Seems like stars variable may need to be refactored to implement useState()

open-sauced/src/components/RepositoryGoals.js

Lines 51 to 54 in 42472e2

    
           const data = repository && repository.data && repository.data.text && JSON.parse(repository.data.text); 
        
           const viewerStars = repository && repository.stars && repository.stars.text && JSON.parse(repository.stars.text); 
        
           const stars = remainingStars(data, viewerStars);

git-srinivas · 2021-10-13T05:45:55Z

.take

github-actions · 2021-10-13T05:46:08Z

Thanks for taking this on! If you have not already, join the conversation in our Discord

0-vortex · 2021-10-21T06:42:38Z

A visual and sorting fix is dropping in #1247 - that doesn't solve the issue of adding repositories in the UI or to the open-sauced-goals repository however it should simplify the local state changes required to make adding duplicates impossible from the UI.

Hope this helps!

0-vortex · 2022-01-01T17:23:20Z

@git-srinivas are you still keen to work on this?

github-actions · 2022-10-13T23:13:08Z

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

closes #1459 closes #1219

closes #1459 closes #1219 a3bd798

### [0.53.5](v0.53.4...v0.53.5) (2022-10-24) ### 🐛 Bug Fixes * correct duplicate repositories added to dashboard ([#1468](#1468)) ([a3bd798](a3bd798)), closes [#1459](#1459) [#1219](#1219)

github-actions · 2022-10-24T22:58:02Z

🎉 This issue has been resolved in version 0.53.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

git-srinivas added 🐛 bug 👀 needs triage labels Oct 9, 2021

mtfoley mentioned this issue Oct 12, 2021

fix: no add response #1220

Merged

15 tasks

github-actions bot assigned git-srinivas Oct 13, 2021

0-vortex removed the 👀 needs triage label Oct 21, 2021

RozzaysRed mentioned this issue Oct 13, 2022

fix: Duplicate repositories can be added to dashboard #1468

Merged

19 tasks

0-vortex closed this as completed in #1468 Oct 24, 2022

0-vortex pushed a commit that referenced this issue Oct 24, 2022

fix: correct duplicate repositories added to dashboard (#1468)

a3bd798

closes #1459 closes #1219

github-actions bot pushed a commit that referenced this issue Oct 24, 2022

fix: correct duplicate repositories added to dashboard (#1468)

95ae77e

closes #1459 closes #1219 a3bd798

github-actions bot added the released label Oct 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug: duplicate repositories can be added to dashboard #1219

Bug: duplicate repositories can be added to dashboard #1219

git-srinivas commented Oct 9, 2021 •

edited

Loading

mtfoley commented Oct 9, 2021

0-vortex commented Oct 10, 2021

git-srinivas commented Oct 10, 2021 •

edited

Loading

0-vortex commented Oct 10, 2021

0-vortex commented Oct 10, 2021

git-srinivas commented Oct 10, 2021

git-srinivas commented Oct 10, 2021

0-vortex commented Oct 10, 2021

git-srinivas commented Oct 10, 2021 •

edited

Loading

mtfoley commented Oct 11, 2021

mtfoley commented Oct 13, 2021

git-srinivas commented Oct 13, 2021

github-actions bot commented Oct 13, 2021

0-vortex commented Oct 21, 2021

0-vortex commented Jan 1, 2022

github-actions bot commented Oct 13, 2022

github-actions bot commented Oct 24, 2022

Bug: duplicate repositories can be added to dashboard #1219

Bug: duplicate repositories can be added to dashboard #1219

Comments

git-srinivas commented Oct 9, 2021 • edited Loading

Describe the bug

Steps to reproduce

Affected services

Platforms

Browsers

Environment

Additional context

Code of Conduct

mtfoley commented Oct 9, 2021

0-vortex commented Oct 10, 2021

git-srinivas commented Oct 10, 2021 • edited Loading

0-vortex commented Oct 10, 2021

0-vortex commented Oct 10, 2021

git-srinivas commented Oct 10, 2021

git-srinivas commented Oct 10, 2021

0-vortex commented Oct 10, 2021

git-srinivas commented Oct 10, 2021 • edited Loading

mtfoley commented Oct 11, 2021

mtfoley commented Oct 13, 2021

git-srinivas commented Oct 13, 2021

github-actions bot commented Oct 13, 2021

0-vortex commented Oct 21, 2021

0-vortex commented Jan 1, 2022

github-actions bot commented Oct 13, 2022

github-actions bot commented Oct 24, 2022

git-srinivas commented Oct 9, 2021 •

edited

Loading

git-srinivas commented Oct 10, 2021 •

edited

Loading

git-srinivas commented Oct 10, 2021 •

edited

Loading