Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year end update to simulators. #339

Closed
wants to merge 5 commits into from
Closed

Conversation

rcornwell
Copy link
Member

General updates to my simulators. These patches should not be flattened as they refer to multiple simulators.

@markpizz
Copy link
Contributor

More warnings...

1>i7090_cpu.c
1>..\I7000\i7090_cpu.c(3415) : error C2220: warning treated as error - no 'object' file generated
1>..\I7000\i7090_cpu.c(3415) : warning C4244: 'function' : conversion from 't_uint64' to 'int', possible loss of data

1>i7080_cpu.c
1>..\I7000\i7080_cpu.c(2571) : error C2220: warning treated as error - no 'object' file generated
1>..\I7000\i7080_cpu.c(2571) : warning C4101: 'ta' : unreferenced local variable
1>..\I7000\i7080_cpu.c(2570) : warning C4101: 'j' : unreferenced local variable
1>..\I7000\i7080_cpu.c(2629) : warning C4101: 'ta' : unreferenced local variable
1>..\I7000\i7080_cpu.c(2628) : warning C4101: 'j' : unreferenced local variable

@markpizz
Copy link
Contributor

Looks OK now. Are you going to squash those extra repair commits?

@rcornwell
Copy link
Member Author

I can backup and repush the I7000 patches.

        I7010 updated to pass diagnostics.
        I7080 updated to pass diagnostics.
        I7090 updated to better pass 9IOT
              updated to allow Stress and other applications to run better.
        Updated card punch to allow input of card decks for overpunching.
@markpizz
Copy link
Contributor

markpizz commented Jan 1, 2024

Does this fix #325?

@rcornwell
Copy link
Member Author

Yes

@pkoning2
Copy link
Member

pkoning2 commented Feb 1, 2024

I wonder why the "rebase and merge" button shows up red and not active.

@pkoning2
Copy link
Member

pkoning2 commented Feb 1, 2024

Perhaps it's the failed test build, but I can't see how to get it to run again, it looks like a random glitch.

@rcornwell
Copy link
Member Author

Do you need me to recreate this PR?

@pkoning2
Copy link
Member

pkoning2 commented Feb 1, 2024

Probably not, if we can figure out how to rerun the failed test.

@markpizz
Copy link
Contributor

markpizz commented Feb 1, 2024

The failed test had nothing to do with these simulators.

This PR is good to merge.

@pkoning2
Copy link
Member

pkoning2 commented Feb 1, 2024

Thanks, I thought that was the case. Do you know how to get the "Rebase and merge" button to come to life?

@markpizz
Copy link
Contributor

markpizz commented Feb 1, 2024

Do you know how to get the "Rebase and merge" button to come to life?

I never used that functionality in the web interface since i always merged and tested locally before pushing the results directly.

@pkoning2
Copy link
Member

pkoning2 commented Feb 1, 2024

Ok, so I did it that way. The disadvantage is that GitHub doesn't recognize it as a merge since it's a rebase, so I have to close this PR manually and its status is confusing (it should be "merged").

Merged.

@pkoning2 pkoning2 closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants