-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Conan 2 #109
Merged
Merged
Upgrade to Conan 2 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to fix glibc incompatibility issues between conanio container and Node.js runtime.
kyllingstad
force-pushed
the
feature/conan-2
branch
from
February 22, 2024 08:20
c3c9bd5
to
dd6d31f
Compare
I've just updated this PR a bit to enable the use of CMake presets created by Conan, which is really convenient. I've updated the README and CI workflow accordingly. |
eidekrist
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested resulting artifact on Windows, works beautifully!
This was referenced Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on open-simulation-platform/libcosim#747. (Once that PR has been merged, the version specification of the
libcosim
requirement should be changed so it no longer points to theosp/testing-feature...
branch.)I had to switch from a simple
conanfile.txt
to a more involvedconanfile.py
because the "import" functionality has been removed in Conan 2. Initially this seemed like a hassle, but in the end, it turned out to be beneficial:generate()
method.