Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when removing variables from trend #54

Open
eidekrist opened this issue Feb 6, 2019 · 1 comment
Open

Crash when removing variables from trend #54

eidekrist opened this issue Feb 6, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@eidekrist
Copy link
Member

When removing variables from trend, an exceptional situation may arise.

The operation clears the slice structs.SimulationStatus.TrendSignals. If the program is simultaneously iterating over this slice (fetching time series), the program may go down due to an out of bounds exception.

This was previously solved with a mutex which made things horribly sluggish at times.
@eidekrist eidekrist added the bug Something isn't working label Feb 6, 2019
@eidekrist
Copy link
Member Author 

panic: runtime error: index out of range

goroutine 51 [running]:
cse-server-go/cse.removeAllFromTrend(0xc00014a050, 0xc000438080, 0x81ff71, 0x1, 0x0, 0x0, 0xc000431d48)
        D:/JenkinsOSP/workspace/on-platform_cse-server-go_v0.5.0/src/cse-server-go/cse/trending.go:82 +0x383
cse-server-go/cse.executeCommand(0xc000004040, 0x2, 0x2, 0xc00014a050, 0xc000438080, 0xc000d941d0, 0xb, 0x0, 0x0, 0x0, ...)
        D:/JenkinsOSP/workspace/on-platform_cse-server-go_v0.5.0/src/cse-server-go/cse/cse.go:625 +0x528
cse-server-go/cse.CommandLoop(0xc00013a0c0, 0xc00014a050, 0xc00013a060, 0xc000438080)
        D:/JenkinsOSP/workspace/on-platform_cse-server-go_v0.5.0/src/cse-server-go/cse/cse.go:679 +0xb8
created by main.main
        D:/JenkinsOSP/workspace/on-platform_cse-server-go_v0.5.0/src/cse-server-go/main.go:25 +0x222

hplatou pushed a commit that referenced this issue May 13, 2020
@flakstad
Merge pull request #54 from open-simulation-platform/feature/user-int…
de20a25 
…eraction-improvement-adding-trends

feature(ux): several user experience improvements #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eidekrist