Uploading artifacts to jfrog #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhjp01
added a commit
that referenced
this pull request
Feb 19, 2024
* Upgrade to Conan 2 This fixes issue #718 (and incidentally fixes #702 too). The modified `<gsl/util>` imports and various changes from `int` to `std::size_t` are a consequence of using a newer version of MS GSL. I changed the dependency version so we can use an upstream CMake package configuration file which is compatible with the one generated by Conan 2's `CMakeDeps` generator. This should enable us to use the same `find_package()` commands and target names regardless of whether the build is running under Conan or not. This also removes the ability to run Conan from within CMake, because upstream hasn't released a version of the cmake-conan helper script with full support for all Conan 2 features yet. (Notably, support for the `CMakeToolchain` generator is missing.) * Update GH Actions workflows for Conan 2 * Use a conanio Docker image that has Conan 2 * Run pure-CMake CI build in Docker, drop Windows * Fix minor mistake in workflow file * Fix more small mistakes in CI * More legible build matrix elements in non-Conan CI * Ensure that libdl is listed as a dependency of fmilib::shared * Also import proxyfmu executable to the build directory * Update version numbers in README * Clean up GitHub Actions workflows a bit * Set the cpp_info property `cmake_target_name` as `libcosim::cosim` in the `package_info` method. This is because otherwise CMakeDeps incorrectly generates the dependency in the target cmake file as `libcosim::libcosim`. (i.e. <consumer>-Target-release.cmake, see https://docs.conan.io/2/reference/tools/cmake/cmakedeps.html#generated-files). This would not be found via `find_package(libcosim REQUIRED)`. * Uploading artifacts to jfrog (#751) gcc9 builds are not available from conancenter. Built libraries are uploaded to osp jfrog. * Updated proxyfmu * Updated version.txt to 0.10.3 --------- Co-authored-by: David Heejong Park <hee.jong.park@dnv.com> Co-authored-by: David Heejong Park <88651540+davidhjp01@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc9 builds are not available from conancenter. Built libraries are uploaded to osp jfrog.