Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert thrift to 0.13.0 #35

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Revert thrift to 0.13.0 #35

merged 1 commit into from
Sep 2, 2021
+1 −1

Conversation

markaren
Copy link
Collaborator

@markaren markaren commented Sep 2, 2021

Closes #34

@ljamt
Copy link
Member

ljamt commented Sep 2, 2021

Seems that this is not an issue with 0.13.0.
Should it be posted as an issue at apache/thrift?

@ljamt ljamt self-requested a review September 2, 2021 13:23
ljamt
ljamt approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@ljamt ljamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reached 55 000 seconds for the Damper case now. Still running.

@restenb
Copy link
Member

restenb commented Sep 2, 2021

Running the tutorial mass-spring-damper case also for over 40 000 seconds with no crash issues.

Crash was consistently reproducible at slightly above 18 000 seconds with thrift 0.14. LGTM.

@markaren markaren merged commit cba316c into master Sep 2, 2021
@markaren markaren deleted the revert-thrift branch September 2, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamt ljamt ljamt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thrift 1.14.x eventually throws an exception
3 participants
@markaren @ljamt @restenb