Rollback thrift to 0.13.0 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 48b43f2.
…d to match the version that `thrift` uses (which changes over time).
restenb
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Strange problem, it seems most likely to be with Thrift somehow. Proxyfmu doesn't do much during a simulation except call get_X, set_X and do_step.
I guess there could be a problem with one of those - perhaps these asserts:
assert(values.size() == vr.size());
but then the caller would have to suddenly send in an incorrectly sized vector.
We could probably isolate the problem by introducing logging in each get_X and do_step function. A good time to do a toggleable debug log PR perhaps?
kyllingstad
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest thrift (0.17.0) is still causing a problem #36.
Rolling it back to 0.13.0 until we find a proper fix