merged master into lfu browser cache

open-source-labs · Apr 9, 2021 · ca1a2c0 · ca1a2c0
1 parent 595c0b3
commit ca1a2c0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/src/lfuBrowserCache.js b/src/lfuBrowserCache.js
@@ -57,8 +57,8 @@ export default function LFUCache(capacity) {
 }
 
 /**
- * @param {number} key
- * @return {number}
+ * @param {string} key
+ * @return {object}
  */
 LFUCache.prototype.get = function (key) {
   let node = this.nodeHash.get(key);
@@ -76,8 +76,8 @@ LFUCache.prototype.get = function (key) {
 };
 
 /**
- * @param {number} key
- * @param {number} value
+ * @param {string} key
+ * @param {object} value
  * @return {void}
  */
 LFUCache.prototype.put = function (key, value) {

diff --git a/test_files/rhum_test_files/lfuBrowserCache_test.ts b/test_files/rhum_test_files/lfuBrowserCache_test.ts
@@ -20,7 +20,7 @@ Rhum.testPlan('LFU Browser Cache Testing', () => {
       async () => {
         const cache = new LFUCache(10);
         await cache.write(test.nestedObj.queryStr, test.nestedObj.respObj);
-        for (let key in test.nestedObj.expectedCache) {
+        for (let key of Object.keys(test.nestedObj.expectedCache)) {
           await Rhum.asserts.assertEquals(
             cache.get(key),
             test.nestedObj.expectedCache[key]

diff --git a/test_files/test_variables/lfuBrowserCache_variables.ts b/test_files/test_variables/lfuBrowserCache_variables.ts
@@ -12,7 +12,7 @@ export const test: { [index: string]: any } = {
         lastName
       }
     }}`,
-    rootQuery: { 'Movie(id:1)': ['Movie~1'] }, // recheck this line, should include actors
+    rootQuery: { 'Movie(id:1)': ['Movie~1'] },
     expectedCache: {
       'Movie~1': {
         title: 'Indiana Jones and the Last Crusade',
@@ -37,7 +37,6 @@ export const test: { [index: string]: any } = {
             __typename: 'Movie',
             id: '1',
             title: 'Indiana Jones and the Last Crusade',
-            // actors: ['Actor~1', 'Actor~2'],
             actors: [
               {
                 __typename: 'Actor',