Fix inconsistency when build both shared/static lib #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xkszltl
suggested changes
Nov 4, 2020
src/lib_json/CMakeLists.txt
Outdated
| set(STATIC_LIB ${PROJECT_NAME}_static) | ||
| else() | ||
| set(STATIC_LIB ${PROJECT_NAME}_lib) | ||
| endif() | ||
| add_library(${STATIC_LIB} STATIC ${PUBLIC_HEADERS} ${JSONCPP_SOURCES}) | ||
|
|
||
| # avoid name clashes on windows as the shared import lib is alse named jsoncpp.lib |
| @@ -160,7 +164,7 @@ if(BUILD_STATIC_LIBS) | |||
| endif() | |||
|
|
|||
| set_target_properties(${STATIC_LIB} PROPERTIES | |||
| OUTPUT_NAME jsoncpp${STATIC_SUFFIX} | |||
| OUTPUT_NAME jsoncpp | |||
There was a problem hiding this comment.
I would recommend to keep them different (and consistent across versions) to support packaging of dual (shared+static) build.
As you may noticed MSVC generates import lib (.lib) for .dll, which should not be confused with static .lib.
| @@ -151,7 +151,11 @@ if(BUILD_SHARED_LIBS) | |||
| endif() | |||
|
|
|||
| if(BUILD_STATIC_LIBS) | |||
| set(STATIC_LIB ${PROJECT_NAME}_static) | |||
| if (BUILD_SHARED_LIBS) | |||
| set(STATIC_LIB ${PROJECT_NAME}_static) | |||
There was a problem hiding this comment.
You can add_library(<default name> ALIAS jsoncpp_static) or add_library(<default name> INTERFACE) and them `target_link_libraries( INTERFACE jsoncpp_static)
|
Closing this due to inactivity. Feel free to reopen if you are able to address feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @SpaceIm please check this patch if it solves your issue.