Fixes PreventInSourceBuilds.cmake to work with add_subdirectory #1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything blocking this PR? We're hitting this issue in https://github.com/protocolbuffers/protobuf and had to downgrade to 1.9.4 because of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes, while still preventing in-source builds for the
jsoncppproject, allow in-source builds for other projects possibly importingjsoncppvia CMake'sadd_subdirectory(). Without these changes, theAssureOutOfSourceBuildswill check for the src and build dirs of the root project, not necessarily of thejsoncppproject.