Add makeCharReader function to deprecated newCharReader #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_ptr to ensure correct memory management
…ion return unique_ptr, in order to prevent breaking changes, mark the newCharReader function as deprecated
BillyDonahue
requested changes
Jul 26, 2022
BillyDonahue
requested changes
Jul 28, 2022
BillyDonahue
requested changes
Jul 28, 2022
BillyDonahue
requested changes
Aug 5, 2022
BillyDonahue
requested changes
Aug 22, 2022
| @@ -2990,6 +2990,19 @@ JSONTEST_FIXTURE_LOCAL(ReaderTest, allowNumericKeysTest) { | |||
| checkParse(R"({ 123 : "abc" })"); | |||
| } | |||
|
|
|||
| struct UniqueReaderTest : JsonTest::TestCase {}; | |||
There was a problem hiding this comment.
Separate fixture not needed. Just make it a member of CharReaderTest.
| @@ -2990,6 +2990,19 @@ JSONTEST_FIXTURE_LOCAL(ReaderTest, allowNumericKeysTest) { | |||
| checkParse(R"({ 123 : "abc" })"); | |||
| } | |||
|
|
|||
| struct UniqueReaderTest : JsonTest::TestCase {}; | |||
|
|
|||
| JSONTEST_FIXTURE_LOCAL(UniqueReaderTest, parseWithNoErrors) { | |||
There was a problem hiding this comment.
The intent of this test is to exercise makeCharReader, not "parseWithNoErrors".
|
|
||
| JSONTEST_FIXTURE_LOCAL(UniqueReaderTest, parseWithNoErrors) { | ||
| Json::CharReaderBuilder b; | ||
| CharReaderPtr reader = b.makeCharReader(); |
There was a problem hiding this comment.
use the explicit return type of makeCharReader here to make the test more clear.
There was a problem hiding this comment.
Let's assert the value of reader since we're specifically testing the factory.
| @@ -337,6 +340,9 @@ class JSON_API CharReaderBuilder : public CharReader::Factory { | |||
| CharReaderBuilder(); | |||
| ~CharReaderBuilder() override; | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Use Doxygen comment /**.
Compress to 1-line.
|
Closing this due to inactivity. Feel free to reopen if you are able to address feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is the result of #1422 discussion