-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bazel tests #1601
Open
bcsgh
wants to merge
5
commits into
open-source-parsers:master
Choose a base branch
from
bcsgh:bcsgh/bazel-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Bazel tests #1601
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1ecfc09
Expose JSON_USE_EXCEPTION and JSON_HAS_INT64 as Bazel config flags wi…
bcsgh 8751d15
#ifdef stuff that should only be used with JSON_USE_EXCEPTION.
bcsgh 8fcfda4
Modify runjsontests.py to allow passing a single test case file.
bcsgh 0383d14
Add tests to the Bazel builds.
bcsgh bb4ac3c
Reverse the polarity to fix a bug.
bcsgh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,3 +12,8 @@ module( | |
version = "1.9.7", | ||
compatibility_level = 1, | ||
) | ||
|
||
bazel_dep( | ||
name = "bazel_skylib", | ||
version = "1.7.1", | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
cc_binary( | ||
name = "jsontestrunner", | ||
srcs = ["main.cpp"], | ||
deps = ["//:jsoncpp"], | ||
visibility = ["//test:__pkg__"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
cc_test( | ||
name = "jsoncpp_test", | ||
srcs = [ | ||
"jsontest.cpp", | ||
"jsontest.h", | ||
"main.cpp", | ||
"fuzz.h", | ||
"fuzz.cpp", | ||
], | ||
deps = ["//:jsoncpp"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
filegroup( | ||
name = "expected", | ||
srcs = glob(["data/**", "jsonchecker/**"], exclude=["**/*.json"]), | ||
) | ||
|
||
[py_test( | ||
name = "runjson_%s_test" % "_".join(f.split("/")), | ||
srcs = ["runjsontests.py"], | ||
main = "runjsontests.py", | ||
args = [ | ||
"--with-json-checker", | ||
"$(location //src/jsontestrunner:jsontestrunner)", | ||
"$(location :%s)" % f, | ||
], | ||
data = [ | ||
"//src/jsontestrunner:jsontestrunner", | ||
":expected", | ||
":%s" % f, | ||
], | ||
) for f in glob(["**/*.json"])] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exceptions should be on by default, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an abstract question, that's debatable (as in there are good arguments either way). But, given that the existing Bazel build has them off by default, I think backwards compatibility requires keeping them that way.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: probably a discussion that should be on the record of #1601 (unless you want to merge just this PR and not that one).