Stack limit #166
Merged
Stack limit #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an improper solution. If multiple Readers exist, then the effect stackLimit is reduced because of side-effects. But our options are limited. We need to address the security hole without breaking binary-compatibility. However, this is not likely to cause any practical problems because: * Anyone using `operator>>(istream, Json::Value)` will be using the new code already * Multiple Readers are uncommon. * The stackLimit is quite high. * Deeply nested JSON probably would have hit the system limits anyway.
cdunn2001
force-pushed
the
stackLimit
branch
from
fdb5f51 to
56df206
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad input should not cause seg-fault.